feat: svelte 5 #298
Merged
feat: svelte 5 #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit updates numerous config files and dependencies across the monorepo, with major changes including: 1. Upgrade Svelte to v5 2. Upgrade ESLint ecosystem to v9 3. Simplify PNPM workspace configuration 4. Upgrade Vite to v6 Here's a suggested commit message: ``` chore: update dependencies and configs for monorepo Update dependencies and config files across monorepo: - Upgrade Svelte to v5 - Update ESLint ecosystem to v9 - Upgrade Vite to v6 - Update configs for new versions - Simplify pnpm workspace config ``` I've used the extended commit message body since this is a significant change affecting multiple packages and systems that deserves more detailed explanation.
Deploying svelte-markdoc-preprocess with
|
| Latest commit: |
3c49c53
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://28bb4e47.svelte-markdoc-preprocess.pages.dev |
| Branch Preview URL: | https://feat-svelte-5.svelte-markdoc-preprocess.pages.dev |
There was a problem hiding this comment.
Pull Request Overview
This pull request upgrades the project to support Svelte 5 while addressing configuration updates and cleanup. Key changes include updating the Playwright testing configuration, adding a new ESLint configuration file for Svelte, and incorporating additional end-to-end tests and CI workflow adjustments.
Reviewed Changes
Copilot reviewed 37 out of 50 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/demo/playwright.config.ts | Updated the test configuration to use defineConfig and changed the test directory from 'tests' to 'e2e'. |
| apps/demo/eslint.config.js | Introduced a new ESLint configuration that integrates TypeScript and Svelte support. |
| apps/demo/e2e/demo.test.ts | Added new Playwright tests for Svelte-related functionality. |
| apps/demo/README.md | Updated documentation for Svelte project creation and usage. |
| apps/demo/.eslintrc.cjs | Removed deprecated ESLint configuration file. |
| .github/workflows/test.yml | Adjusted the test command syntax in the CI workflow. |
| .github/workflows/lint.yml | Added a build step before linting in the CI workflow. |
Files not reviewed (13)
- apps/demo/.eslintignore: Language not supported
- apps/demo/.gitignore: Language not supported
- apps/demo/.npmrc: Language not supported
- apps/demo/.prettierignore: Language not supported
- apps/demo/.prettierrc: Language not supported
- apps/demo/package.json: Language not supported
- apps/demo/src/app.html: Language not supported
- apps/demo/src/lib/Nodes.svelte: Language not supported
- apps/demo/src/lib/Tags.svelte: Language not supported
- apps/demo/src/lib/layouts/Alternative.svelte: Language not supported
- apps/demo/src/lib/layouts/Default.svelte: Language not supported
- apps/demo/src/lib/nodes/Fence.svelte: Language not supported
- apps/demo/src/lib/nodes/Heading.svelte: Language not supported
Comments suppressed due to low confidence (3)
apps/demo/playwright.config.ts:8
- Verify that the test directory change from 'tests' to 'e2e' is intentional and update the documentation if needed.
testDir: 'e2e'
apps/demo/eslint.config.js:12
- Confirm that using ts.config from 'typescript-eslint' is correct for this configuration, and review the API if unexpected behavior occurs.
export default ts.config(
.github/workflows/lint.yml:17
- [nitpick] Validate that running 'pnpm run build' in the lint workflow is intentional, as it may increase CI times and might not be necessary for linting.
- run: pnpm run build
Updates numerous package dependencies to newer versions across the project. Key updates include: - Svelte updated to 5.25.5 - TypeScript to 5.8.2 - Prettier to 3.5.3 - Various build tools and plugins upgraded - Core dependencies bumped to latest compatible versions - Development dependencies refreshed The changes appear to be routine dependency maintenance to keep the project up-to-date with latest stable releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #269