Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushed Jena version to 5.0.0 and updated Caching library #177

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jerdebsp
Copy link

@jerdebsp jerdebsp commented May 26, 2024

Hi,

I was having trouble using 1.4.3 due to Jena classes deprecated or removed - more specifically org.apache.jena.graph.Factory. In my pull request, i've updated Jena to the latest version and also updated the Caching library to use benmanes (https://github.com/ben-manes/caffeine) which is compatible with the previously used library. I believe that the library used in the main fork is not available anymore.

Thanks,
Jeremy

PS. I couldn't assign anyone as reviewer. I guess Holger or Ashley can do this.

@@ -72,7 +72,7 @@ public MultiUnion createMultiUnion(Graph[] graphs) {
* @return the default Graph
*/
public Graph createDefaultGraph() {
return Factory.createDefaultGraph();
return GraphFactory.createDefaultGraph();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Should this be a call to `JenaUtil.createDefaultGraph()?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason JenaUtil.createDefaultGraph() is calling the helper class, causing a stack overflow cycle

This is what there is in JenaUtil.
public static Graph createDefaultGraph() { return helper.createDefaultGraph(); }
Maybe this needs to be changed?

src/main/java/org/topbraid/jenax/util/JenaUtil.java Outdated Show resolved Hide resolved
src/main/java/org/topbraid/shacl/arq/SHACLARQFunction.java Outdated Show resolved Hide resolved
@costas80
Copy link

costas80 commented Jul 5, 2024

Hey @jerdebsp . Is this PR blocked? I see discussion about a stack overflow from the review by @afs but no clear resolution.

@jerdebsp
Copy link
Author

jerdebsp commented Jul 5, 2024

That comment was for why I did not use JenaUtil.createDefaultGraph(). I think the PR is still blocked for now until Java (on the CI) is updated from 17 to 21 or 22.

If you are using java 21 or 22, you can download my branch and use it. I am using it for project work and training and so far it seems to work well

@afs
Copy link
Contributor

afs commented Oct 26, 2024

The latest Jena release is 5.2.0.

@costas80
Copy link

@jerdebsp, if you update Jena to the latest version, maybe @ashleycaselli, or @HolgerKnublauch could have a look at the CI issue and merge this?

@jerdebsp
Copy link
Author

I will try to update to Jena 5.2.0 by end of next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants