-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pushed Jena version to 5.0.0 and updated Caching library #177
base: master
Are you sure you want to change the base?
Conversation
@@ -72,7 +72,7 @@ public MultiUnion createMultiUnion(Graph[] graphs) { | |||
* @return the default Graph | |||
*/ | |||
public Graph createDefaultGraph() { | |||
return Factory.createDefaultGraph(); | |||
return GraphFactory.createDefaultGraph(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: Should this be a call to `JenaUtil.createDefaultGraph()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason JenaUtil.createDefaultGraph()
is calling the helper class, causing a stack overflow cycle
This is what there is in JenaUtil.
public static Graph createDefaultGraph() { return helper.createDefaultGraph(); }
Maybe this needs to be changed?
That comment was for why I did not use If you are using java 21 or 22, you can download my branch and use it. I am using it for project work and training and so far it seems to work well |
The latest Jena release is 5.2.0. |
@jerdebsp, if you update Jena to the latest version, maybe @ashleycaselli, or @HolgerKnublauch could have a look at the CI issue and merge this? |
I will try to update to Jena 5.2.0 by end of next week |
Hi,
I was having trouble using 1.4.3 due to Jena classes deprecated or removed - more specifically org.apache.jena.graph.Factory. In my pull request, i've updated Jena to the latest version and also updated the Caching library to use benmanes (https://github.com/ben-manes/caffeine) which is compatible with the previously used library. I believe that the library used in the main fork is not available anymore.
Thanks,
Jeremy
PS. I couldn't assign anyone as reviewer. I guess Holger or Ashley can do this.