Show version name while deleting #4589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
deployed https://tj-4589.herokuapp.com/ |
|
Screenshot for reference: |
kavinvenkatachalam
requested changes
Oct 25, 2022
There was a problem hiding this comment.
@FroostyCodes Thanks for the PR.
Instead of looping and finding the name of the version, we can maintain it in the state. We already have a deletingVersionId state which can be changed to deletingVersion and maintain both { id: version.id, name: version.name } in the state. This avoids an unnecessary loop to find the name of the version.
|
Hey @FroostyCodes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4575