[docs]: Audio issue in text input video #3998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shivangT
commented
Sep 9, 2022
shivangT
commented
- Fixed the video and updated the new video link
shivangT
added
bug
|
Shivang Tiwari seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
gsmithun4
added a commit
that referenced
this pull request
Jan 10, 2023
* [docs] Provide border to the images (#3853) * replaced class with classname to provide image border * removed unnecessary div, added alt attribute in image tags Co-authored-by: Shivang Tiwari <shivangtiwari@Shivangs-MacBook-Pro.local> * Cypress test for button widget happy path (#3776) * Add and modify data-cy attribute for elements * Modify faker file for random rgba hex code * Add methods specific for button widget * Add and modify common selector and text file * Add and modify common widget methods * Modify button text file * Modify button widget happy path file * Remove button selector file * Modify multiselect widget happy with new methods * Modify verify box shadow css method * Add and modify common selector file * Modify button text file * add and modify specific methods for button widget * Add and modify custom commands * Add and modify common widget methods * Add app preview and modify button widget happy path * Add and modify data-cy attribute for elements * Modify multiselect widget happy with new methods * Modify data-cy attributes * Add review changes * Add data-cy attribute * Add review changes Co-authored-by: arpitnath <arpitnath42@gmail.com> * refactor: update sentry sdk + add profiler (#3938) * refactor: remove @babel/plugin-proposal-class-properties (2nd PR after CLA problem) (#3959) * refactor: remove @babel/plugin-proposal-class-properties as plugin * Remove class properties plugin from babel.config.js, Update frontend package.json, Update frontend,server,plugin package.lock.json * [docs] how to - Bulk update multiple rows in table (#3864) * [ Bugfix ] :: calendar preview is broken when events are added as a result of any query (#3928) * fix :: checking type of events to assign empty array initially * cleanup * checking array * [docs] renamed filenames to correct redirection links from the editor (#3974) Co-authored-by: Shivang Tiwari <shivangtiwari@Shivangs-MacBook-Pro.local> * [docs] how-to: access currentUser properties (#3977) * how to user and group * hot-to/access current user props * [Plugins] Add support for self-hosted Baserow (#3969) * Add support for self-hosted baserow * docs:updated * Make tooltip text for hide query visible (#3918) * [feature] Hide apps in dashboard (#3888) * - Added new field under app view permission - Added new column to appGroupPermission * added queries for hiding app from dashboard * changed a column name * Create query panel component (#3966) * refactor: create query panel component * prop typo fix * [docs] setting up on a subpath (#3984) * [docs] added image for query body details (#3988) Co-authored-by: Shivang Tiwari <shivangtiwari@Shivangs-MacBook-Pro.local> * [docs] created missing svg image doc (#3985) Co-authored-by: Shivang Tiwari <shivangtiwari@Shivangs-MacBook-Pro.local> * Bug fixed : canvas background colour is not consistent with the applied theme (#3956) * Bug fixed : canvas background colour is not consistent with the applied theme * bug fixed : canvas color is not consistent in the Viewer mode * reverting back changes made earlier * reverting back changes made earlier * bug fixed : canvas background in editor is not consistent with the applied theme * Bug fixed : Viewer component is not consistent with the applied theme * [docs] updated new video link (#3998) Co-authored-by: Shivang Tiwari <shivangtiwari@Shivangs-MacBook-Pro.local> * bug fixed : Password Input widget is not consistent with the dark theme (#3992) * Bug fixed : radio button is not consistent with the dark theme (#3929) * Bug fixed : Button Group widget is not consistent with the dark theme (#3950) * Fix test in Listview (#4012) * Bug fixed : Pagination widget is not consistent with the dark theme (#3946) * bug fixed : Pagination widget is not consistent with the dark theme * removed console.log * Bug fixed : Tree Select widget is not consistent with the dark theme (#3948) * Bug fixed : Tree Select widget is not consistent with the dark theme * only setting up condition for #000 * removed includes function * [Bugfix] fixes app freeze, when password widget drops inside a listview (#4018) * fixes app freeze, when password widget drops inside a listview * fix:darkmode * bug fixed : toggle switch is not consistent with the dark theme (#3925) * bug fixed : Text input widget is not consistent with the dark theme (#3990) * Bug fixed : dark theme issues (#4009) * bug fixed : file picker is not consistent with the dark theme * bug fixed : Map widget is not consistent with the dark theme * bug fixed : Steps widget is not consistent with the dark theme * bug fixed : Multi select widget label is not consistent with the dark theme * bug fixed : search bar in widget manager and label params in Code Hinter is not consistent with the dark theme * removed unwanted comma in the chart inspector * bug fix : app dropdown inside go to app in event manager is not consistent with the dark theme * bug fixed : search select dropdown is not consistent with the dark theme in table inspector * bug fixed : Organization and Profile avatar in HomePage is not consistent with the dark theme * bug fixed : search box in the homepage is not consistent with the dark theme * bug fixed : select dropdown input placeholder is not consistent with the dark theme * bug fixed :Text area in the Modal to Share the app link is not consistent with the dark theme * bug fixed : p tag in pagination in the homepage is not consistent with the dark theme * replaced undefined to false as default value of darkMode if not defined * bug fixed : multiselect input placeholder is not consistent with the dark theme * removed duplicate code from custom.scss and changed rgb to hex in theme.scss * Bug fix : Container widget background color is not consistent with the dark theme (#3866) * Bug fix : Container widget background color is not consistent with the dark theme * replaced two condition checks with one * made the suggested changes * removed console.log * [Feature]: Added Localisation (#3746) * Added localisation * Closed modal after language selection * updated transaltaion setup * Updated language tooltip * Added fallback language support * Adding english library resource for translation (#3844) * Adding English dictionary for the widget lists in the inspector * added leftSideBar object in en.json and implemented it for leftSidebar icon text * renamed leftSideBar to leftSidebar and added resources for tip in the left side bar * added english translation resources for leftsidebar debugger * added english language resources for the global settings * added english language resources for data sources in left sidebar * added english language resources for the share button and share modal in the editor * added english language resources for release button, manageOrgUsers, appVersionManager * added english language resources for Queries and Please select a widget to inspect in the editor * added english language resources for data source list , data source manager, and query manager(partially) * added english language resources for queryManager, transformation, preview * added english language resources for dark mode toggle in the headers inside homepage * added fallback message for dark mode toggle * added resources for language change in the headers inside homepage * added resources for notification center in the header inside homepage * added resources for organization and manage users components in header inside homepage * added resources in manageGroupPermission * added resources for manageGroupPermissionsResources component * added resources for manageSSO and generalSettings components * added resources for google sso * added resources for github sso * added resources for environment variables in manageSSO * added resources for profile and setting page * added resources for app card and app card menu * added resources for folder section and app list in homepage * added resources for header section in the homepage * added resources for pagination in homepage * added resources for modals in the homepage * added resources for blank page * added resources for login page * added resources for forgot password page * added resources for sign up page * added resources for onBoarding component * added resources for reset password page * deleted duplicate key for readDocumentation * deleted duplicate key for cancel in en.json and added translation for cancel at few places * removing duplicate copy of save key in en.json * added translation for CommentActions.jsx components * deleted duplicate copy of search key in en.json and added resources for create and search queries , select keys * fix typo errors * fixed typo errors * shorten the key for loginAndSignUpAndForgotPassword to loginSignupPage in en.json file and related files * shorten the key noLoginMethodsEnabledForThisWorkspace to noLoginMethodsEnabled * shorten the key pleaseCheckYourEmailForConfirmationLink to emailConfirmLink * shorten the key dontHaveAccountYet to dontHaveAccount * shorten keys from loginSignupPage key in en.json * shorten keys of shareModal nested object in en.json * shorten the key in appVersionManager nested object * shorten the keys for queryManager nested object in the en.json * delete duplicate copy of environmentVar and shorten manageEnvironmentVariables,environmentVariables * shorten keys in the organization nested object * shorten keys in the homePage nested object in en.json file * added inspector and eventManager empty object * added resources to RedirectSSO component * added resources for OAuth2 * added resources for TemplateCard.jsx * added resources for TemplateLibraryModal.jsx * added resources for ConfirmationPage.jsx * added resources for ConfirmationPage component * removed translation in App.jsx file * added resources for Slack.jsx * added resources for GoogleSheets.jsx * added resources for CodeBuilder.jsx * added resources for CommentBody and CommentFooter * added resources for TestConnection component * added resources for AllignButton.jsx * added resources for Openapi and Stripe components * added resources for ErrorBoundary * added resources for Viewer.jsx * Translation for widgets, table Co-authored-by: Kavin Venkatachalam <kavin.saratha@gmail.com> * Commented Language selection * Fixed typos * Updated fr.json file Co-authored-by: Manish Kushare <kushare.manish9@gmail.com> * Bug fixed : List view widget background color is not consistent with the dark theme (#3867) * Bug fixed : list view widget background color is not consistent with the dark theme * replaced two condition check with one * Fixed : If we pick white (#FFFFFF) then the dark mode is not handled. * Add preview for Multiselect and Datepicker happyPaths (#3854) * Modify data-cy and update spec * Add data-cy * Add preview for multiSelect * Add preview for datePicker * Fix Text data-cy * Modify selectors and texts * Resolve conflicts and commented few lines of code. * Fix: User group permissions error on Openshift platform (#4041) * update dockerfile for file permissions on root group * add permissions from the user group on dockerfile * bump to v1.24.4 * bump to v1.25.0 * [feature] Added pagination and filtering features to users page (#3921) * added pagination and filtering in backend * added pagination - created a seperate component for users table - added pagination * Added filter UI * temporary css fix for pagination footer * fixed pagination width issue * now result will also clear when user clicks on clear icon * Added seperate api for comment mentions * Now we can search mentions by email, first and last names * Fixed a bug - email didn't send for comment mentions * refactoring the code * resolved PR changes * Added isAdmin guard * adding some checks * fixed lint errors * added wild card search * Added no result found text * fixed failing test case * Working on PR changes * Now users table avatars will load image too * replaced skeleton classes with skeleton library component * Completed PR changes * added orderby * Fixed some issues * fixed failed test case * have fixed some css issues * replaced query with quersrting package * fixed minor width issue * Fixed some css issues * fixed darkMode issue * implemented on enter press search * Refactored the code * fixed white space issue * refactored the code * fixed overlapping issue * refactored the code * fixing some issues * fixes * removed guard * code cleanup * comments notification fix * fixed conflict issues * fixed css height issue Co-authored-by: gsmithun4 <gsmithun4@gmail.com> * Remove signup guard from set-password-from-token API (#4050) * Remove sign up guard set-password-from-token API * test cases fix * Bump to v1.25.1 * style changes * css changes * css fix Co-authored-by: Shivang <32157641+shivangT@users.noreply.github.com> Co-authored-by: Shivang Tiwari <shivangtiwari@Shivangs-MacBook-Pro.local> Co-authored-by: Ajith KV <ajith.jaban@gmail.com> Co-authored-by: arpitnath <arpitnath42@gmail.com> Co-authored-by: Gandharv <gandharvkumargarg@gmail.com> Co-authored-by: Akshay Sasidharan <akshaysasidharan93@gmail.com> Co-authored-by: Erfan Naghashlou <62594996+erfan93na@users.noreply.github.com> Co-authored-by: Kiran Ashok <stepinfwd@gmail.com> Co-authored-by: Shubhendra Singh Chauhan <withshubh@gmail.com> Co-authored-by: Roei Yaacobi <roeiyaacobi@gmail.com> Co-authored-by: Muhsin Shah C P <muhsinshah21@gmail.com> Co-authored-by: Sherfin Shamsudeen <sherfin94@gmail.com> Co-authored-by: Manish Kushare <kushare.manish9@gmail.com> Co-authored-by: mikebarr24 <89523154+mikebarr24@users.noreply.github.com> Co-authored-by: Kavin Venkatachalam <50441969+kavinvenkatachalam@users.noreply.github.com> Co-authored-by: Midhun Kumar E <midhun752@gmail.com>
gsmithun4
added a commit
that referenced
this pull request
Jan 10, 2023
* [docs] Provide border to the images (#3853) * replaced class with classname to provide image border * removed unnecessary div, added alt attribute in image tags Co-authored-by: Shivang Tiwari <shivangtiwari@Shivangs-MacBook-Pro.local> * Cypress test for button widget happy path (#3776) * Add and modify data-cy attribute for elements * Modify faker file for random rgba hex code * Add methods specific for button widget * Add and modify common selector and text file * Add and modify common widget methods * Modify button text file * Modify button widget happy path file * Remove button selector file * Modify multiselect widget happy with new methods * Modify verify box shadow css method * Add and modify common selector file * Modify button text file * add and modify specific methods for button widget * Add and modify custom commands * Add and modify common widget methods * Add app preview and modify button widget happy path * Add and modify data-cy attribute for elements * Modify multiselect widget happy with new methods * Modify data-cy attributes * Add review changes * Add data-cy attribute * Add review changes Co-authored-by: arpitnath <arpitnath42@gmail.com> * refactor: update sentry sdk + add profiler (#3938) * refactor: remove @babel/plugin-proposal-class-properties (2nd PR after CLA problem) (#3959) * refactor: remove @babel/plugin-proposal-class-properties as plugin * Remove class properties plugin from babel.config.js, Update frontend package.json, Update frontend,server,plugin package.lock.json * [docs] how to - Bulk update multiple rows in table (#3864) * [ Bugfix ] :: calendar preview is broken when events are added as a result of any query (#3928) * fix :: checking type of events to assign empty array initially * cleanup * checking array * [docs] renamed filenames to correct redirection links from the editor (#3974) Co-authored-by: Shivang Tiwari <shivangtiwari@Shivangs-MacBook-Pro.local> * [docs] how-to: access currentUser properties (#3977) * how to user and group * hot-to/access current user props * [Plugins] Add support for self-hosted Baserow (#3969) * Add support for self-hosted baserow * docs:updated * Make tooltip text for hide query visible (#3918) * [feature] Hide apps in dashboard (#3888) * - Added new field under app view permission - Added new column to appGroupPermission * added queries for hiding app from dashboard * changed a column name * Create query panel component (#3966) * refactor: create query panel component * prop typo fix * [docs] setting up on a subpath (#3984) * [docs] added image for query body details (#3988) Co-authored-by: Shivang Tiwari <shivangtiwari@Shivangs-MacBook-Pro.local> * [docs] created missing svg image doc (#3985) Co-authored-by: Shivang Tiwari <shivangtiwari@Shivangs-MacBook-Pro.local> * Bug fixed : canvas background colour is not consistent with the applied theme (#3956) * Bug fixed : canvas background colour is not consistent with the applied theme * bug fixed : canvas color is not consistent in the Viewer mode * reverting back changes made earlier * reverting back changes made earlier * bug fixed : canvas background in editor is not consistent with the applied theme * Bug fixed : Viewer component is not consistent with the applied theme * [docs] updated new video link (#3998) Co-authored-by: Shivang Tiwari <shivangtiwari@Shivangs-MacBook-Pro.local> * bug fixed : Password Input widget is not consistent with the dark theme (#3992) * Bug fixed : radio button is not consistent with the dark theme (#3929) * Bug fixed : Button Group widget is not consistent with the dark theme (#3950) * Fix test in Listview (#4012) * Bug fixed : Pagination widget is not consistent with the dark theme (#3946) * bug fixed : Pagination widget is not consistent with the dark theme * removed console.log * Bug fixed : Tree Select widget is not consistent with the dark theme (#3948) * Bug fixed : Tree Select widget is not consistent with the dark theme * only setting up condition for #000 * removed includes function * [Bugfix] fixes app freeze, when password widget drops inside a listview (#4018) * fixes app freeze, when password widget drops inside a listview * fix:darkmode * bug fixed : toggle switch is not consistent with the dark theme (#3925) * bug fixed : Text input widget is not consistent with the dark theme (#3990) * Bug fixed : dark theme issues (#4009) * bug fixed : file picker is not consistent with the dark theme * bug fixed : Map widget is not consistent with the dark theme * bug fixed : Steps widget is not consistent with the dark theme * bug fixed : Multi select widget label is not consistent with the dark theme * bug fixed : search bar in widget manager and label params in Code Hinter is not consistent with the dark theme * removed unwanted comma in the chart inspector * bug fix : app dropdown inside go to app in event manager is not consistent with the dark theme * bug fixed : search select dropdown is not consistent with the dark theme in table inspector * bug fixed : Organization and Profile avatar in HomePage is not consistent with the dark theme * bug fixed : search box in the homepage is not consistent with the dark theme * bug fixed : select dropdown input placeholder is not consistent with the dark theme * bug fixed :Text area in the Modal to Share the app link is not consistent with the dark theme * bug fixed : p tag in pagination in the homepage is not consistent with the dark theme * replaced undefined to false as default value of darkMode if not defined * bug fixed : multiselect input placeholder is not consistent with the dark theme * removed duplicate code from custom.scss and changed rgb to hex in theme.scss * Bug fix : Container widget background color is not consistent with the dark theme (#3866) * Bug fix : Container widget background color is not consistent with the dark theme * replaced two condition checks with one * made the suggested changes * removed console.log * [Feature]: Added Localisation (#3746) * Added localisation * Closed modal after language selection * updated transaltaion setup * Updated language tooltip * Added fallback language support * Adding english library resource for translation (#3844) * Adding English dictionary for the widget lists in the inspector * added leftSideBar object in en.json and implemented it for leftSidebar icon text * renamed leftSideBar to leftSidebar and added resources for tip in the left side bar * added english translation resources for leftsidebar debugger * added english language resources for the global settings * added english language resources for data sources in left sidebar * added english language resources for the share button and share modal in the editor * added english language resources for release button, manageOrgUsers, appVersionManager * added english language resources for Queries and Please select a widget to inspect in the editor * added english language resources for data source list , data source manager, and query manager(partially) * added english language resources for queryManager, transformation, preview * added english language resources for dark mode toggle in the headers inside homepage * added fallback message for dark mode toggle * added resources for language change in the headers inside homepage * added resources for notification center in the header inside homepage * added resources for organization and manage users components in header inside homepage * added resources in manageGroupPermission * added resources for manageGroupPermissionsResources component * added resources for manageSSO and generalSettings components * added resources for google sso * added resources for github sso * added resources for environment variables in manageSSO * added resources for profile and setting page * added resources for app card and app card menu * added resources for folder section and app list in homepage * added resources for header section in the homepage * added resources for pagination in homepage * added resources for modals in the homepage * added resources for blank page * added resources for login page * added resources for forgot password page * added resources for sign up page * added resources for onBoarding component * added resources for reset password page * deleted duplicate key for readDocumentation * deleted duplicate key for cancel in en.json and added translation for cancel at few places * removing duplicate copy of save key in en.json * added translation for CommentActions.jsx components * deleted duplicate copy of search key in en.json and added resources for create and search queries , select keys * fix typo errors * fixed typo errors * shorten the key for loginAndSignUpAndForgotPassword to loginSignupPage in en.json file and related files * shorten the key noLoginMethodsEnabledForThisWorkspace to noLoginMethodsEnabled * shorten the key pleaseCheckYourEmailForConfirmationLink to emailConfirmLink * shorten the key dontHaveAccountYet to dontHaveAccount * shorten keys from loginSignupPage key in en.json * shorten keys of shareModal nested object in en.json * shorten the key in appVersionManager nested object * shorten the keys for queryManager nested object in the en.json * delete duplicate copy of environmentVar and shorten manageEnvironmentVariables,environmentVariables * shorten keys in the organization nested object * shorten keys in the homePage nested object in en.json file * added inspector and eventManager empty object * added resources to RedirectSSO component * added resources for OAuth2 * added resources for TemplateCard.jsx * added resources for TemplateLibraryModal.jsx * added resources for ConfirmationPage.jsx * added resources for ConfirmationPage component * removed translation in App.jsx file * added resources for Slack.jsx * added resources for GoogleSheets.jsx * added resources for CodeBuilder.jsx * added resources for CommentBody and CommentFooter * added resources for TestConnection component * added resources for AllignButton.jsx * added resources for Openapi and Stripe components * added resources for ErrorBoundary * added resources for Viewer.jsx * Translation for widgets, table Co-authored-by: Kavin Venkatachalam <kavin.saratha@gmail.com> * Commented Language selection * Fixed typos * Updated fr.json file Co-authored-by: Manish Kushare <kushare.manish9@gmail.com> * Bug fixed : List view widget background color is not consistent with the dark theme (#3867) * Bug fixed : list view widget background color is not consistent with the dark theme * replaced two condition check with one * Fixed : If we pick white (#FFFFFF) then the dark mode is not handled. * Add preview for Multiselect and Datepicker happyPaths (#3854) * Modify data-cy and update spec * Add data-cy * Add preview for multiSelect * Add preview for datePicker * Fix Text data-cy * Modify selectors and texts * Resolve conflicts and commented few lines of code. * Fix: User group permissions error on Openshift platform (#4041) * update dockerfile for file permissions on root group * add permissions from the user group on dockerfile * bump to v1.24.4 * bump to v1.25.0 * [feature] Added pagination and filtering features to users page (#3921) * added pagination and filtering in backend * added pagination - created a seperate component for users table - added pagination * Added filter UI * temporary css fix for pagination footer * fixed pagination width issue * now result will also clear when user clicks on clear icon * Added seperate api for comment mentions * Now we can search mentions by email, first and last names * Fixed a bug - email didn't send for comment mentions * refactoring the code * resolved PR changes * Added isAdmin guard * adding some checks * fixed lint errors * added wild card search * Added no result found text * fixed failing test case * Working on PR changes * Now users table avatars will load image too * replaced skeleton classes with skeleton library component * Completed PR changes * added orderby * Fixed some issues * fixed failed test case * have fixed some css issues * replaced query with quersrting package * fixed minor width issue * Fixed some css issues * fixed darkMode issue * implemented on enter press search * Refactored the code * fixed white space issue * refactored the code * fixed overlapping issue * refactored the code * fixing some issues * fixes * removed guard * code cleanup * comments notification fix * fixed conflict issues * fixed css height issue Co-authored-by: gsmithun4 <gsmithun4@gmail.com> * Remove signup guard from set-password-from-token API (#4050) * Remove sign up guard set-password-from-token API * test cases fix * Bump to v1.25.1 * Feature: Add PG_DB_OWNER env var to disable db and extension creation (#4055) * add PG_DB_OWNER env var to disable db and extension creation * update docs * bump to v1.25.2 * hotfix: handle pg env vars from env and env file * bump to v1.25.3 * [Feature] Now multiple users can login through RestAPI-Oauth 🚀 (#4052) * Implemented multiple access token feature - working on refresh token case * worked on refresh token flow * added multiple token ability to openapi plugin too - fixed some bugs * changed tokenData to token_data - fixed some issues * added user type with user id * changed user type * Rewrote some function - added switch for enabling and disable multi auth - fixed some bugs - refactored the code * fixed view app issue * Fixed public app issue * cleaning some code * (public_app) add a check to avoid oauth login redirect when there is no access token * reverted all changes of openapi (temporary) - will add multi token functionality once done with restapi * fixed a bug * fixed a bug * refactored some code * changed the switch text * pr changes * changed token_data back to tokenData * cleaning code * removed token data from datasources query * removed some lines * added a comment * bump to v1.25.4 * audit logs fix Co-authored-by: Shivang <32157641+shivangT@users.noreply.github.com> Co-authored-by: Shivang Tiwari <shivangtiwari@Shivangs-MacBook-Pro.local> Co-authored-by: Ajith KV <ajith.jaban@gmail.com> Co-authored-by: arpitnath <arpitnath42@gmail.com> Co-authored-by: Gandharv <gandharvkumargarg@gmail.com> Co-authored-by: Akshay Sasidharan <akshaysasidharan93@gmail.com> Co-authored-by: Erfan Naghashlou <62594996+erfan93na@users.noreply.github.com> Co-authored-by: Kiran Ashok <stepinfwd@gmail.com> Co-authored-by: Shubhendra Singh Chauhan <withshubh@gmail.com> Co-authored-by: Roei Yaacobi <roeiyaacobi@gmail.com> Co-authored-by: Muhsin Shah C P <muhsinshah21@gmail.com> Co-authored-by: Sherfin Shamsudeen <sherfin94@gmail.com> Co-authored-by: Manish Kushare <kushare.manish9@gmail.com> Co-authored-by: mikebarr24 <89523154+mikebarr24@users.noreply.github.com> Co-authored-by: Kavin Venkatachalam <50441969+kavinvenkatachalam@users.noreply.github.com> Co-authored-by: Midhun Kumar E <midhun752@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.