Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazily load agents in proxy-agent #327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

addaleax
Copy link

@addaleax addaleax commented Aug 7, 2024

Some of the references packages can be quite expensive to instantiate (e.g. pac-proxy-agent and its custom JS runtime), so lazily loading them enables fast loading times for the more common cases.

Some of the references packages can be quite expensive to instantiate
(e.g. pac-proxy-agent and its custom JS runtime), so lazily loading them
enables fast loading times for the more common cases.
Copy link

changeset-bot bot commented Aug 7, 2024

🦋 Changeset detected

Latest commit: bce985e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
proxy-agent Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
proxy-agents ✅ Ready (Inspect) Visit Preview Aug 7, 2024 1:42pm

@developit
Copy link

Just wanted to give a major thumbs up to this - proxy-agents is a dependency of Puppeteer, which is used in CI a lot. In our setup, we actually went to the length of stubbing pac-proxy-agent via require.cache to prevent it from being loaded (the entire proxy-agent setup is unused by puppeteer for anyone not using a proxy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants