Support headers for http-proxy-agent
#175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 301862f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TooTallNate
reviewed
May 18, 2023
packages/http-proxy-agent/README.md
Outdated
| ### new HttpProxyAgent(proxy: string | URL, options?: HttpProxyAgentOptions) | ||
|
|
||
| The `HttpProxyAgent` class implements an `http.Agent` subclass that connects | ||
| to the specified "HTTP(s) proxy server" in order to proxy HTTP and/or WebSocket |
There was a problem hiding this comment.
Suggested change
| to the specified "HTTP(s) proxy server" in order to proxy HTTP and/or WebSocket | |
| to the specified "HTTP(s) proxy server" in order to proxy HTTP |
TooTallNate
reviewed
May 18, 2023
packages/http-proxy-agent/README.md
Outdated
|
|
||
| The `HttpProxyAgent` class implements an `http.Agent` subclass that connects | ||
| to the specified "HTTP(s) proxy server" in order to proxy HTTP and/or WebSocket | ||
| requests. This is achieved by using the [HTTP `CONNECT` method][CONNECT]. |
There was a problem hiding this comment.
http-proxy-agent does not use CONNECT.
There was a problem hiding this comment.
Oops, I copy/pasted this part without thinking, good catch thanks! Fixed in 301862f
TooTallNate
approved these changes
May 18, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, HttpProxyAgent does not have a
headersoption at all. The HttpsProxyAgent does, though.This PR adds a
headersoption, allowing consumers to set the proxy headers statically or dynamically.Companion PR to update HttpsProxyAgent: #174