Update build.gradle #785
Merged
Update build.gradle #785
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marci4
approved these changes
Oct 12, 2018
|
Hello @theAprel, thank you very much for your pull request! For my jenkins setup I just use maven so I forgot to update everything! Best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
gradle.buildto include the new logging dependencies.Related Issue
#784
Motivation and Context
Maven was updated for these dependencies, but gradle was not. I'm assuming since this project still contains a
gradle.buildfile, it's meant to still support gradle.How Has This Been Tested?
I ran
./gradle build. Instead of "BUILD FAILED" I see "BUILD SUCCESSFUL".Types of changes
Checklist: