Skip to content

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Nov 1, 2017

Also removed assert() in WebSocketClient runnable since it has no
understandable purpose!

Description

Removed assert() in WebSocketClientRunnable
Improved OpeningHandshakeRejection test

Related Issue

Motivation and Context

Cleanup

How Has This Been Tested?

Standard JUnit-Tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Also removed assert() in WebSocketClient runnable since it has no
understandable purpose!
@marci4 marci4 merged commit 84b94b5 into TooTallNate:master Nov 1, 2017
@marci4 marci4 added this to the Release 1.3.6 milestone Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant