Fix e race problem when starting server with port 0 (issue 362) #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm starting the server with a port of 0, so I can then immediately open a client of the server, without hard-wiring in a specific port. Before I start the client, I need to call getPort(). But that may not work, since the server field may not have been set yet, and that happens in a separate thread. My suggestion is to move the initial socket.bind to the start method, before the run method in the new thread.
|
See issue #362 . |
|
Hello @PerBothner Would it also just be sufficient for you to get a notification that the server startet up successfully? Greetings |
|
No, because if the requested port number is zero, I also need to know the actual port number. Note I am no longer using Java-WebSocket (I'm using libwebsockets instead), so this is no longer an issue for me or my projects. |
|
I may have misunderstood the question: The problem is solved if I can reliably get the actual port number after start-up. (However, I'm still sticking with libwebsockets. Glad to see this project is alive again, though.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm starting the server with a port of 0, so I can then immediately
open a client of the server, without hard-wiring in a specific
port. Before I start the client, I need to call getPort(). But that
may not work, since the server field may not have been set yet, and
that happens in a separate thread. My suggestion is to move the
initial socket.bind to the start method, before the run method in the
new thread.