fix: correct days-to-merge log output to display actual days #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The daysToMerge/daysToClose values are stored in seconds (legacy naming), but the log output was displaying raw seconds as if they were days. This made values like -398601 appear as bugs when they actually represented about -4.6 days correctly. Now converts to actual days before logging for clarity.
Contributor
🤖 Worlddriven Status📊 Live Status Dashboard🗓️ Merge Date: 2025-12-16 at 04:16:35 UTC (today) 🎯 Want to influence when this merges?Your review matters! As a contributor to this project, your voice helps determine the merge timeline. How to review:
Your options:
💡 Pro tip: The more contributors who agree, the faster this gets merged! 📊 View detailed stats on the dashboard 📋 Recent Activity• 2025-12-14, 08:45:31 - Pull request opened This comment is automatically updated by worlddriven |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
-398601now correctly display as-4.61daysContext
The
daysToMergeanddaysToClosevariables are named misleadingly - they actually store seconds, not days. The log output was printing raw seconds as "Days to merge: -398601.582" which looked like a bug.The actual calculation was correct - a PR scheduled to merge on Dec 9th and checked on Dec 14th is correctly ~4.6 days past deadline.
Test plan