chore: drop dev-container notes from CLAUDE.md, bump to 1.3.2 - #29
Open
patrickmelix wants to merge 1 commit into
Open
chore: drop dev-container notes from CLAUDE.md, bump to 1.3.2#29patrickmelix wants to merge 1 commit into
patrickmelix wants to merge 1 commit into
Conversation
The "Environment notes (this dev container)" section documented an SSH agent socket path (/ssh-agent) specific to one contributor's local container. It doesn't generalize to other machines or contributors, and per a stacked PR (#28) the path is already stale in that container too. This is a public repo's dev guide, not a place for one machine's local setup notes. Bumping the version since there's no other pending release-worthy change queued for this PR.
There was a problem hiding this comment.
Pull request overview
This PR prepares a metadata-only release of tools4vasp by removing contributor-specific dev-container guidance from the shared development guide and bumping project version metadata for an auto-published release on merge.
Changes:
- Remove non-portable dev-container SSH agent notes from
CLAUDE.md. - Bump package version from
1.3.1to1.3.2inpyproject.toml. - Update release metadata in
CITATION.cff(version +date-released).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
CLAUDE.md |
Removes stale/non-portable dev-container environment notes from the contributor guide. |
pyproject.toml |
Bumps the package version to 1.3.2 to trigger the release workflow on merge. |
CITATION.cff |
Updates citation metadata to match the new release version/date. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| 'scipy >= 1.10.0', | ||
| ] | ||
| version = "1.3.1" | ||
| version = "1.3.2" |
Comment on lines
+6
to
+7
| version: "1.3.2" | ||
| date-released: "2026-07-30" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.md. It documented an SSH agent socket path (/ssh-agent) specific to one contributor's local dev container — not portable to other machines/contributors, and per the stacked PR fix: correct electronic-entropy sign so vaspcheck's entropy test can fire #28 handoff, already stale even in that container. This is a public repo's dev guide, not the place for one machine's local setup notes.pyproject.tomlandCITATION.cff(incl.date-released), since there's no other release-worthy change queued right now. Notetag-on-merge.ymlwill auto-tag and publish to PyPI on merge tomain.Test plan
CLAUDE.md,pyproject.toml,CITATION.cff🤖 Generated with Claude Code