Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for adding padding on element or parent #39

Merged
merged 4 commits into from
Aug 3, 2022
Merged

Fixes for adding padding on element or parent #39

merged 4 commits into from
Aug 3, 2022

Conversation

ponnexcodev
Copy link
Collaborator

Screenshot 2022-08-03 103221

@netlify
Copy link

netlify bot commented Aug 3, 2022 •
edited
Loading

✅ Deploy Preview for gleeful-bunny-4be1e2 ready!

Name Link
🔨 Latest commit 1f710d8
🔍 Latest deploy log https://app.netlify.com/sites/gleeful-bunny-4be1e2/deploys/62eb02bf086b640009bb9fe7
😎 Deploy Preview https://deploy-preview-39--gleeful-bunny-4be1e2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@electrovir electrovir added the bug Something isn't working label Aug 3, 2022
electrovir
electrovir approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@electrovir electrovir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the console log but looks great otherwise so approving! Thanks for the examples in the storybook!

src/elements/toniq-slider/toniq-slider.element.ts Outdated Show resolved Hide resolved
@ponnexcodev ponnexcodev merged commit 6c7be53 into main Aug 3, 2022
@electrovir electrovir deleted the toniq-slider-padding-fixes branch August 8, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrovir electrovir electrovir approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ponnexcodev @electrovir