Fix multi-agent record_transition to check all agents for episode completion#443
Closed
darshmenon wants to merge 1 commit into
Closed
Fix multi-agent record_transition to check all agents for episode completion#443darshmenon wants to merge 1 commit into
darshmenon wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #289.
Problem
MultiAgent.record_transitionusesnext(iter(terminated.values()))andnext(iter(truncated.values()))to determine which environments finished an episode. This only checks the first agent in the dictionary, so if any other agent terminates first, the cumulative rewards and timesteps are not reset and tracking is wrong.Fix
Replace the single-agent check with a logical OR across all agents:
PyTorch backend (
multi_agents/torch/base.py):JAX backend (
multi_agents/jax/base.py):An episode is considered finished when any agent signals termination or truncation — consistent with cooperative multi-agent environments where agents share a joint episode boundary.