This repository was archived by the owner on May 5, 2025. It is now read-only.
Added modals showing details about clans/players #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added API /clans/{tag}
Extracted addColors to Utils.php
Added ext-json as dependency
Added bootstrap.js
Added style.css with colors from 0 to 9
Added route view for details (modal)
Tomut0
reviewed
Apr 7, 2021
Tomut0
reviewed
Apr 7, 2021
Tomut0
reviewed
Apr 7, 2021
Tomut0
reviewed
Apr 7, 2021
Tomut0
reviewed
Apr 7, 2021
Tomut0
reviewed
Apr 7, 2021
Tomut0
reviewed
Apr 7, 2021
Tomut0
reviewed
Apr 7, 2021
Tomut0
reviewed
Apr 7, 2021
Tomut0
reviewed
Apr 7, 2021
Tomut0
reviewed
Apr 7, 2021
2. Add colors.scss and settings for its compiling * style.css | auto-compiled version for production
Tomut0
reviewed
Apr 7, 2021
Tomut0
reviewed
Apr 7, 2021
| let nick = element.dataset.nick; | ||
| if (tag) { | ||
| element.onclick = () => showClan(tag) | ||
| } else if (nick) { |
Collaborator
Author
There was a problem hiding this comment.
So it won't add a listener that does nothing except print "invalid id" on log.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added API /clans/{tag}
Extracted addColors to Utils.php
Added ext-json as dependency
Added bootstrap.js
Added style.css with colors from 0 to 9
Added route view for details (modal)