Skip to content

When conda building, get "Built wheel for ccpi-viewer is invalid" error #333

Closed

Description

When we run actions we consistently get this:
https://github.com/vais-ral/CILViewer/actions/runs/3524392336/jobs/5909735176#step:4:587

WARNING: Built wheel for ccpi-viewer is invalid: Metadata 1.2 mandates PEP 440 version, but '22.4.0-26-gd763c8c' is not
DEPRECATION: ccpi-viewer was installed using the legacy 'setup.py install' method, because a wheel could not be built for it. pip 23.1 will enforce this behaviour change. A possible replacement is to fix the wheel build issue reported above. Discussion can be found at pypa/pip#8368

I believe we need to move this line:
https://github.com/vais-ral/CILViewer/blob/9ebd5ea3246007e1267cf9298f61a75ea3c73304/Wrappers/Python/setup.py#L48
out of the if statement so that we are always converting the version to pep440 compatible. Currently it only happens if we aren't conda building.

What was the original reason behind only converting this if we aren't conda building?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions