Is the project still active?

[fbele]

Hi,
I personally like the idea behind this project and I do appreciate your endeavor, however I must ask if this project is still active?
I am asking this because there are quite a few bugs in the source code and I went through your blog about the project and many of the things that are included in your repo are not addressed and explained

Bugs:

1. The project cannot run on Android emulator as the build fails BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 63 in ../ionic-sveltekit-ssr-demo/android/capacitor.settings.gradle
2. I know that there was something already written in the other issue about this, but preview npm run preview of the built version of the app throws error: .svelte-kit/output/server/chunks/pwa.store.js:21 if ("serviceWorker" in navigator) { ReferenceError: navigator is not defined
3. In pwa.store.ts file there is an import error Cannot find module 'virtual:pwa-register/svelte' or its corresponding type declarations.
4. I believe that FAQ question items should open somehow to show the answers, which doesn't work. I do see that there is a script in the dist for that but nevertheless it is not working. Also the template for FAQ is throwing errors for props like toggleElement.
5. If you navigate from Landing page to Install page and then back, some of the components are not being shown anymore.
6. tsconfig.json file is throwing error Cannot find type definition file for 'ionic-svelte'.

Missing documentation or explanation:

1. There is a manifest defined in vite.config.js and there is another manifest file in static folder .static/manifest.webmanifest. Is that intentional? Maybe one for the build and the other one for local development?
2. What are browserconfig.xml, sw.js, workbox-7369c0e1.js for? Are these generated files at the time of build compilation? Because all of these files are then being included in the build itself too.

I do hope these things get fixed. Or is it maybe something that I am doing something wrong?
Because the blog is explaining exactly what I want to achieve which is to have PWA or mobile version of the webpage routed differently than browser version.

Thanks for your effort.

[Tommertom]

Thanks for the extensive feedback and I appreciate you taking the time.

As to many of the technical issues you raise I can only say that I would need to really replay what you are doing to see if that also gives error. This specific project was to illustrate a way of approaching Ionic with SSR even though there are limitations to that. It is not necessarily intended as a boilerplate/starting point for a bullet-proof project.

The ionic-svelte project is definitely alive, but also requiring a full overhaul/re-engineering to get to the next stage, solving many issues related to native UI feel when navigating.

Many things you mention could be explained in the blog, but that would bloat it.

As for the manifest, indeed that is to cover for the error in dev as index.html links to it
The browserconfig - I believe it is generated or so. I did not intentionally put it there. sw.js is the service worker? And workbox is a dependency.

To me it is a matter of time to be working on many issues. Updating ionic-svelte library would then be highest priority. This specific project I might update or not.. APIs change so rapidly, it is just too hard keeping up with everything (vite, svelte, ionic, vite-pwa, capacitor....)

[fbele]

Thanks for the prompt reply. Please don't take any of what I listed out as a personal criticism, I respect appreciate your work and what you're trying to do here very much! All that I wrote should be considered more as a point of notice if there is further development to be done on the project.

I just cloned this demo, followed the few instructions and tried to run it.
I'm going step by step to implement the feature and try to reproduce it. For example point 3 from the first list can already be resolved with putting the following in tsconfig.json file:

{
  "compilerOptions": {
    "types": [
      "vite-plugin-pwa/svelte"
    ]
  }
}

Point 6 can be resolved be changing the path in tsconfig.json file in typeRoots section from "./node_modules/ionic-svelte" to "./node_modules".

About the redundant files that I mentioned, maybe just few lines should be added in .gitignore file then.

Maybe if I manage to get the project up and running I can fork your repo and upload it.

[Tommertom]

No worries! All good and thanks

Love to learn.

Just sharing my views

👍🏻😀

[fbele]

Hi,

So I took some time yesterday to go over the project and fix the issues that I listed above.
Basically I managed to fix everything, except for point 5 but I know what the issue is. The problem is once you navigate to /app/install route, Ionic styles have been loaded and they stay loaded when you navigate back to Landing page. There should be a way if you navigate back that these styles get "unloaded".

Also one thing to consider is that the beforeinstallprompt event is not really being supported well enough: https://caniuse.com/?search=beforeinstallprompt

If you want I can share/upload my code and findings. Just let me know how and where.

[Tommertom]

Unloading styles is likely a difficult one. after the install I also believe the user should not be able to go back, or just do a full reload to the homepage. Unloading style is a pretty big task as I do not believe that ever thought of as a use case.

The limited support for beforeinstallprompt is a given- iOS is still lagging behind, next to some other browsers..

If you like to do a PR on the current project, then we can see the changes and also helps giving the project some extra reputation. And you will get the credits of course! Will that work.

[fbele]

I've created a PR. Kindly take a look. For any questions you can contact me.

[fbele]

Unloading styles is likely a difficult one. after the install I also believe the user should not be able to go back, or just do a full reload to the homepage. Unloading style is a pretty big task as I do not believe that ever thought of as a use case.

one note to unloading styles and app behavior: I know that this is a difficult one, if not impossible, however from UX perspective I don't think it should be assumed that the user should not or won't navigate back. they can do whatever they feel like. it's up to developer to handle the UX properly.
this comment of mine was just more as a note for whoever is going to use this project, that this is a point of notice where maybe a bit of thought should be put in it.