Prepend "-- " to default query_comment
#64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Athena DDL does not always respect /* ... */ block quotations. This is
the case with (at least) `create external table ...` statements.
Currently, if you try to run `create external table ...` statements, the
following error is returned: `pyathena.error.OperationalError: FAILED:
ParseException line 1:0 cannot recognize input near '/' '*' '{'`
Here I monkey-patched _QueryComment.add to prepend "-- " to the
`query_comment` and replace any newlines with " ".
This allows the default `query_comment` to be added to `create external
table` statements.
We might want to do this so that dbt-labs/dbt-external-tables can add
Athena support as is proposed in dbt-labs/dbt-external-tables/pull/133
Without this modification, the only way to run `dbt run-operation
stage_external_sources --vars "ext_full_refresh: true"` without an error
is to set `query_comment:` to nothing, a specific value, or a macro.
divy9393
reviewed
Feb 23, 2022
divy9393
reviewed
Feb 23, 2022
|
Hey @Tomme - any interest in pulling this in? |
|
@Tomme |
No worries at all - apologies for the delay! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Athena DDL does not always respect /* ... */ block quotations. This is
the case with (at least)
create external table ...statements.Currently, if you try to run
create external table ...statements, thefollowing error is returned:
pyathena.error.OperationalError: FAILED: ParseException line 1:0 cannot recognize input near '/' '*' '{'Here I monkey-patched _QueryComment.add to prepend "-- " to the
query_commentand replace any newlines with " ".This allows the default
query_commentto be added tocreate external tablestatements.We might want to do this so that dbt-labs/dbt-external-tables can add
Athena support as is proposed in dbt-labs/dbt-external-tables/pull/133
Without this modification, the only way to run
dbt run-operation stage_external_sources --vars "ext_full_refresh: true"without an erroris to set
query_comment:to nothing, a specific value, or a macro.