Trying to add BETTER fopen function #407
Draft
+110
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Green-Sky
reviewed
Sep 8, 2025
| ft->line_id = self->chatwin->hst->line_end->id + line_skip; | ||
| ft->state = FILE_TRANSFER_STARTED; | ||
|
|
||
| run_detached("xdg-open", ft->file_path); |
Member
There was a problem hiding this comment.
Does it really make sense to start an ft and immediately open the in-progress file transfer?
Green-Sky
reviewed
Sep 8, 2025
|
|
||
| default: | ||
| line_info_add(self, c_config, false, NULL, NULL, SYS_MSG, 0, 0, "File transfer failed (error %d)\n", err); | ||
| return; |
Member
There was a problem hiding this comment.
This switch should be extracted to its own function (instead of goto).
Also the default case string has an extra new line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed up all the commits from #273 into a single commit, and simplified things a bit. Also using fork and execlp instead of popen now.
Looks better, @nurupo, @Green-Sky, @JFreegman ?
Also tested it and it actually works 🥳
This change is