-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 Rewriting Colorpicker #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Toinane What's the purpose behind the rewrite? Can you jot down some top-level objectives in the description please? |
Done! 👍 |
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
This PR aims to put Colorpicker back on a good foundation for 3.0.0
It will be merged on the dev branch which is now the branch I will use for all new development.
Each new PR on master will mean a new stable version of Colorpicker ( excluding modification of the readme or Github configuration file...)
Here are the goals of this PR:
These are the main lines of this PR. I know it's going to be tedious and time consuming, but it's a work that I need to do to ensure that Colorpicker will be more stable and secure and less volatile than it is now.
On the technology side, I regularly use React for professional projects, although I chose Preact here because it is lighter and allows me to keep my knowledge of React. I don't want the application to be unnecessarily heavier than it already is. Also I took the decision to put Typescript to avoid Javascript errors in the stable versions, this will allow me to make the code cleaner in general.
On the functionality side, the Picker is a very volatile feature because it requires me to use C++ modules not quite adapted. For this, I started to learn C++ to be able to make the Picker directly myself with the help of existing C++ modules. I already have a test version running on Windows and MacOS. For Linux I don't have a fully adapted solution yet. However I have noticed that Rust could be a viable solution for the Picker. So maybe I will migrate to Rust soon. In any case, the Picker will only come in a second time because it will take me a lot of time on its own.
The last point of this PR is also to take into consideration all the issues and solve them here. Some will not be resolved directly in this PR, but I will do my best!
Feel free to comment if you have any questions or comments :)