Skip to content

Conversation

@antoniostrijdom
Copy link

This PR updates the Toggles package to compile with Swift 6 features enabled.

Toggles was already thread safe, so the TogglesFacade could safely be marked as @unchecked.

Note that Object values now require Sendable conformance.

Copy link
Member

@albertodebortoli albertodebortoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend!

@albertodebortoli albertodebortoli merged commit ba9d0a9 into TogglesPlatform:main May 1, 2024
@antoniostrijdom antoniostrijdom deleted the swift-6-support branch May 1, 2024 10:26
],
path: "Sources"),
path: "Sources",
swiftSettings: [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antoniostrijdom were these experimental settings intended to be added here? Only in ToggleCipher and not in ToggleGen, JustTweakMigrator and Toggles?

/// Protocol to be implemented by custom value providers.
/// A ValueProvider allows retrieving values for given variables.
public protocol ValueProvider {
public protocol ValueProvider: Sendable {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antoniostrijdom was this needed on the protocol?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants