-
Notifications
You must be signed in to change notification settings - Fork 6
Swift 6 support #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 6 support #45
Conversation
albertodebortoli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legend!
| ], | ||
| path: "Sources"), | ||
| path: "Sources", | ||
| swiftSettings: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antoniostrijdom were these experimental settings intended to be added here? Only in ToggleCipher and not in ToggleGen, JustTweakMigrator and Toggles?
| /// Protocol to be implemented by custom value providers. | ||
| /// A ValueProvider allows retrieving values for given variables. | ||
| public protocol ValueProvider { | ||
| public protocol ValueProvider: Sendable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antoniostrijdom was this needed on the protocol?
This PR updates the Toggles package to compile with Swift 6 features enabled.
Toggles was already thread safe, so the
TogglesFacadecould safely be marked as@unchecked.Note that
Objectvalues now requireSendableconformance.