collect meta data from threads #989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitsmt211
commented
Dec 17, 2023
Comment on lines
+105
to
+112
| private boolean wasThreadAlreadyHandled(long threadChannelId) { | ||
| // NOTE Discord/JDA fires this event twice per thread (bug?), we work around by remembering | ||
| // the threads we already handled | ||
| Instant now = Instant.now(); | ||
| // NOTE It is necessary to do the "check if exists, otherwise insert" atomic | ||
| Instant createdAt = threadIdToCreatedAtCache.get(threadChannelId, any -> now); | ||
| return createdAt != now; | ||
| } |
There was a problem hiding this comment.
copied method for checking already handled thread, should i instead just increase visibility of one inside HelpThreadCreatedListener?
application/src/main/java/org/togetherjava/tjbot/features/help/MetadataMiner.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #660
gonna close this, there's a better way to do this instead of wriitng seperate listener should be done in already existing one.