-
-
Notifications
You must be signed in to change notification settings - Fork 91
Dynamically enable features with config file #886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
application/src/main/java/org/togetherjava/tjbot/config/FeatureBlacklist.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
package org.togetherjava.tjbot.config; | ||
|
||
import com.fasterxml.jackson.annotation.JsonCreator; | ||
|
||
import java.util.Set; | ||
|
||
/** | ||
* Blacklist of features, use {@link FeatureBlacklist#isEnabled(T)} to test if a feature is enabled. | ||
* If a feature is blacklisted, it won't be enabled by the bot, and so will be ignored. | ||
* | ||
* @param <T> the type of the feature identifier | ||
Zabuzard marked this conversation as resolved.
Show resolved
Hide resolved
|
||
*/ | ||
public class FeatureBlacklist<T> { | ||
private final Set<T> featureIdentifierBlacklist; | ||
|
||
/** | ||
* Creates a feature blacklist | ||
* | ||
* @param featureIdentifierBlacklist a set of identifiers which are blacklisted | ||
*/ | ||
@JsonCreator | ||
public FeatureBlacklist(Set<T> featureIdentifierBlacklist) { | ||
this.featureIdentifierBlacklist = Set.copyOf(featureIdentifierBlacklist); | ||
} | ||
|
||
/** | ||
* Returns if a feature is enabled or not. | ||
* | ||
* @param featureId the identifier of the feature | ||
* @return true if a feature is enabled, false otherwise | ||
*/ | ||
public boolean isEnabled(T featureId) { | ||
return !featureIdentifierBlacklist.contains(featureId); | ||
} | ||
} |
28 changes: 28 additions & 0 deletions
28
application/src/main/java/org/togetherjava/tjbot/config/FeatureBlacklistConfig.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
package org.togetherjava.tjbot.config; | ||
|
||
import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
||
import java.util.Objects; | ||
|
||
/** | ||
* Configuration of the feature blacklist, any feature present here will be disabled. | ||
* | ||
* @param normal the normal features, which are present in | ||
* {@link org.togetherjava.tjbot.features.Features} | ||
* @param special the special features, which require special code | ||
*/ | ||
public record FeatureBlacklistConfig( | ||
@JsonProperty(value = "normal", required = true) FeatureBlacklist<Class<?>> normal, | ||
@JsonProperty(value = "special", required = true) FeatureBlacklist<String> special) { | ||
|
||
/** | ||
* Creates a FeatureBlacklistConfig. | ||
* | ||
* @param normal the list of normal features, must be not null | ||
* @param special the list of special features, must be not null | ||
*/ | ||
public FeatureBlacklistConfig { | ||
Objects.requireNonNull(normal); | ||
Objects.requireNonNull(special); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.