Skip to content

change to getFirst() and getLast() #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 5, 2024
Merged

change to getFirst() and getLast() #1127

merged 6 commits into from
Jun 5, 2024

Conversation

@nefelhhh
Copy link
Contributor

@nefelhhh nefelhhh commented Jun 4, 2024

Closes #1091.

@nefelhhh nefelhhh requested a review from a team as a code owner June 4, 2024 20:05
@CLAassistant
Copy link

CLAassistant commented Jun 4, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

christolis
christolis previously approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@christolis christolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

christolis
christolis previously approved these changes Jun 5, 2024
View reviewed changes
SquidXTV
SquidXTV previously approved these changes Jun 5, 2024
View reviewed changes
Taz03
Taz03 requested changes Jun 5, 2024
View reviewed changes
Copy link
Member

@Taz03 Taz03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TJ-Bot/application/src/main/java/org/togetherjava/tjbot/features/jshell/renderer/RendererUtils.java

Line 63 in 7bc47d6

result.snippetsResults().get(result.snippetsResults().size() - 1).status());

change this also

@nefelhhh nefelhhh force-pushed the refactor/get-first branch from bf98b51 to 317402a Compare June 5, 2024 14:31
@nefelhhh nefelhhh dismissed stale reviews from SquidXTV and christolis via 2c21427 June 5, 2024 14:38
@nefelhhh
Copy link
Contributor Author

nefelhhh commented Jun 5, 2024 •
edited
Loading

TJ-Bot/application/src/main/java/org/togetherjava/tjbot/features/jshell/renderer/RendererUtils.java

Line 63 in 7bc47d6

result.snippetsResults().get(result.snippetsResults().size() - 1).status());

change this also

Fixed!

@SquidXTV SquidXTV merged commit fb8df54 into Together-Java:develop Jun 5, 2024
@ankitsmt211 ankitsmt211 mentioned this pull request Jun 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christolis christolis christolis approved these changes

@Taz03 Taz03 Taz03 approved these changes

@SquidXTV SquidXTV SquidXTV approved these changes

Assignees

@nefelhhh nefelhhh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make use of getFirst/getLast

5 participants

@nefelhhh @CLAassistant @christolis @Taz03 @SquidXTV