Feat: Add slash command to generate application form for various community roles #1049

christolis · 2024-03-08T13:57:49Z

Closes #1024.

Screenshots

Configuration changes

Property	Description	Type	Default
`applicationForm.applicationChannelPattern`	Where submitted applications end up.	String	`"applications-log"`

TODO

Add a 5 minute cooldown per member for sending applications to prevent spam (feel free to recommend alternatives).
- This could be done by having a HashMap<Member, OffsetDateTime> where the key is the Member who sent an application and the value is the date and time that they sent it. There should be a condition every time a Member attempts to send any application which utilizes the aforementioned HashMap to prevent spam.
Add JavaDocs for every method where it's necessary.
~~Switch to EntitySelectInteractionEvent for the dropdown menu.~~ (EDIT: Impossible since this would forcibly include all existing roles)
Move selectable roles from the config to the command parameters in a similar fashion with previous commands.
- This eliminates emoji/description metadata as well that was previously defined in the configuration file.

Suleman70 · 2024-03-08T14:07:18Z

Can i be assigned to this?

Taz03

branch update is required, it is using removed APIs

christolis · 2024-03-19T22:17:24Z

Marked PR as draft since there needs to be some rework on certain things which will be specified in the TODO.

ankitsmt211 · 2024-05-19T01:37:43Z

@christolis what happens to the generated form after x user applies through form? Does the form need to be re-created? Or is it only unavailable for x user to a certain time period?

Also how do we update the form if need be?
Delete message and recreate?

christolis · 2024-10-06T12:42:25Z

@christolis what happens to the generated form after x user applies through form? Does the form need to be re-created? Or is it only unavailable for x user to a certain time period?

Also how do we update the form if need be? Delete message and recreate?

The generated form is persistent and used by everybody. It does not need to be recreated by whoever has the MANAGE_ROLES permission. As for updating it, that's right. Currently, the way it is developed, the message has to be deleted and get the command executed again, which is not that big of a problem considering the rarity of updating such form.

application/src/main/java/org/togetherjava/tjbot/features/basic/ApplicationCreateCommand.java

application/config.json.template

application/src/main/java/org/togetherjava/tjbot/features/basic/ApplicationCreateCommand.java

surajkumar

Great PR and the thought put into the development of the feature is evident.

Please can you look into the comments, additionally, there are some duplicate checks happening e.g. multiple guild == null checks. This can be done once much earlier and then you don't have to worry about it.

application/src/main/java/org/togetherjava/tjbot/features/basic/ApplicationCreateCommand.java

.../src/main/java/org/togetherjava/tjbot/features/roleapplication/ApplicationCreateCommand.java

application/src/main/java/org/togetherjava/tjbot/config/RoleApplicationSystemConfig.java

tj-wazei

LGTM!

.../src/main/java/org/togetherjava/tjbot/features/roleapplication/ApplicationCreateCommand.java

SquidXTV

Thanks for your effort <3

Zabuzard · 2025-06-26T07:44:32Z

application/config.json.template

+        "minimumAnswerLength": 50,
+        "maximumAnswerLength": 500,
+        "applicationSubmitCooldownMinutes": 5


these 3 can be hardcoded. not needed in the config

Zabuzard · 2025-06-26T07:45:31Z

.../src/main/java/org/togetherjava/tjbot/features/roleapplication/ApplicationCreateCommand.java

+ * This command is designed to generate an application form for members to apply for roles within a
+ * guild.
+ */
+public class ApplicationCreateCommand extends SlashCommandAdapter {


the feature should be renamed to match the package name. CreateRoleApplicationCommand

Zabuzard · 2025-06-26T07:47:01Z

...n/src/main/java/org/togetherjava/tjbot/features/roleapplication/ApplicationApplyHandler.java

+ * that submissions are sent to the appropriate application channel, and enforcing cooldowns for
+ * users to prevent spamming.
+ */
+public class ApplicationApplyHandler {


the feature should be renamed to match the package name. RoleApplicationHandler

Zabuzard · 2025-06-26T07:49:15Z

.../src/main/java/org/togetherjava/tjbot/features/roleapplication/ApplicationCreateCommand.java

+    private static final int ARG_COUNT = 3;
+
+    private final ApplicationApplyHandler applicationApplyHandler;
+    private final RoleApplicationSystemConfig roleApplicationSystemConfig;


u can just call it config for simplicity

Zabuzard · 2025-06-26T07:49:36Z

.../src/main/java/org/togetherjava/tjbot/features/roleapplication/ApplicationCreateCommand.java

+    private static final String VALUE_DELIMITER = "_";
+    private static final int ARG_COUNT = 3;
+
+    private final ApplicationApplyHandler applicationApplyHandler;


u could call it just handler for simplicity. context is clear within this class

Zabuzard · 2025-06-26T08:04:12Z

...n/src/main/java/org/togetherjava/tjbot/features/roleapplication/ApplicationApplyHandler.java

+                    .setTimestamp(Instant.now())
+                    .setFooter("Submitted at");
+
+        String roleString = args.getLast();


prefer extracting the args at the beginning, right after ur length check. and id prefer explicit indices here to make sure the thing is at the index u expected. so args.get(1) in this case

Zabuzard · 2025-06-26T08:04:35Z

...n/src/main/java/org/togetherjava/tjbot/features/roleapplication/ApplicationApplyHandler.java

+        if (args.size() != 2 || guild == null) {
+            return;
+        }


sounds like this would be an error case that should emit a log message instead of silent failure?

Zabuzard · 2025-06-26T08:05:07Z

...n/src/main/java/org/togetherjava/tjbot/features/roleapplication/ApplicationApplyHandler.java

+        if (applicationChannel.isEmpty()) {
+            return;
+        }


warning instead of silent failure?

Zabuzard · 2025-06-26T08:05:40Z

...n/src/main/java/org/togetherjava/tjbot/features/roleapplication/ApplicationApplyHandler.java

+                    .setTimestamp(Instant.now())
+                    .setFooter("Submitted at");


prefer reordering these two calls so it tells the story better "Submitted at ... Instant.now()"

Zabuzard · 2025-06-26T08:06:59Z

...n/src/main/java/org/togetherjava/tjbot/features/roleapplication/ApplicationApplyHandler.java

+        return applicationSubmitCooldown;
+    }
+
+    protected void submitApplicationFromModalInteraction(ModalInteractionEvent event,


why protected? this class doesnt make use of inheritance. id remove all the protected and make the class final instead

LovinLifee · 2025-06-27T18:58:12Z

Commenting so I can be assigned

Co-authored-by: Suraj Kumar <76599223+surajkumar@users.noreply.github.com>

This removes the permission check for the bot to have the `MANAGE_ROLES` permission in order to execute the command.

christolis added enhancement New feature or request new command Add a new command or group of commands to the bot priority: major labels Mar 8, 2024

christolis self-assigned this Mar 8, 2024

SquidXTV assigned Suleman70 Mar 8, 2024

christolis marked this pull request as ready for review March 9, 2024 10:17

christolis requested a review from a team as a code owner March 9, 2024 10:17

Suleman70 removed their assignment Mar 16, 2024

Taz03 requested changes Mar 19, 2024

View reviewed changes

christolis force-pushed the feature/application-form branch from 5c0ef6e to 3159bed Compare March 19, 2024 21:28

christolis marked this pull request as draft March 19, 2024 22:16

christolis force-pushed the feature/application-form branch 2 times, most recently from cb7815a to 042a0e0 Compare April 4, 2024 09:48

christolis marked this pull request as ready for review April 4, 2024 22:12

christolis requested a review from Taz03 April 4, 2024 22:18

ankitsmt211 added the config-changes if your PR contains any changes related to config file label May 18, 2024

christolis force-pushed the feature/application-form branch from 1a8e458 to 29c8ee6 Compare October 6, 2024 11:39

SquidXTV requested changes Oct 14, 2024

View reviewed changes

surajkumar suggested changes Oct 14, 2024

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/features/basic/ApplicationCreateCommand.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/basic/ApplicationCreateCommand.java Outdated Show resolved Hide resolved

christolis force-pushed the feature/application-form branch 4 times, most recently from 0b18118 to a8178b9 Compare October 17, 2024 20:02

tj-wazei requested changes Oct 17, 2024

View reviewed changes

tj-wazei reviewed Oct 17, 2024

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/config/RoleApplicationSystemConfig.java Show resolved Hide resolved

tj-wazei previously approved these changes Oct 17, 2024

View reviewed changes

christolis dismissed tj-wazei’s stale review via 0291813 October 17, 2024 20:55

tj-wazei previously approved these changes Oct 17, 2024

View reviewed changes

SquidXTV requested changes Oct 19, 2024

View reviewed changes

.../src/main/java/org/togetherjava/tjbot/features/roleapplication/ApplicationCreateCommand.java Outdated Show resolved Hide resolved

christolis dismissed tj-wazei’s stale review via a226d33 October 19, 2024 19:46

SquidXTV approved these changes Oct 19, 2024

View reviewed changes

Zabuzard requested changes Jun 26, 2025

View reviewed changes

SquidXTV assigned LovinLifee Jun 27, 2025

christolis and others added 8 commits June 28, 2025 00:23

feat: add role application system config

6d8ceee

feat: create role application command

a42a428

Co-authored-by: Suraj Kumar <76599223+surajkumar@users.noreply.github.com>

fix(handle-permissions): remove unnecessary check

dcb241c

This removes the permission check for the bot to have the `MANAGE_ROLES` permission in order to execute the command.

refactor: make cooldown minutes check into separate method

375ae45

feat: move substring of label into config record

8651807

docs: rewrite documentation for RoleApplicationSystemConfig

0a04d90

style: run spotlessApply gradle task

8ab2f40

feat(cooldown): use the proper word depending on count

f46c983

christolis force-pushed the feature/application-form branch from a226d33 to f46c983 Compare June 27, 2025 21:24

Uh oh!

Feat: Add slash command to generate application form for various community roles #1049

Are you sure you want to change the base?

Feat: Add slash command to generate application form for various community roles #1049

Conversation

christolis commented Mar 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

Configuration changes

TODO

Uh oh!

Suleman70 commented Mar 8, 2024

Uh oh!

Taz03 left a comment

Choose a reason for hiding this comment

Uh oh!

christolis commented Mar 19, 2024

Uh oh!

ankitsmt211 commented May 19, 2024

Uh oh!

christolis commented Oct 6, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

surajkumar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tj-wazei left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SquidXTV left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LovinLifee commented Jun 27, 2025

Uh oh!

Uh oh!

christolis commented Mar 8, 2024 •

edited

Loading