Skip to content

Conversation

@devloves
Copy link
Contributor

@devloves devloves commented Mar 1, 2024

Closes issue #1028

Supersedes PR #1032 from a different fork branch with the latest features from develop merged. will be marked as a draft PR before it's ready :)

@christolis christolis mentioned this pull request Mar 1, 2024
@christolis christolis linked an issue Mar 1, 2024 that may be closed by this pull request
@christolis christolis added enhancement New feature or request priority: low labels Mar 1, 2024
@christolis christolis force-pushed the feature/members-count branch 2 times, most recently from 32d5382 to dcc3ab3 Compare March 1, 2024 11:46
christolis and others added 2 commits March 1, 2024 13:48
Co-authored-by: Devansh Tiwari <65783463+devloves@users.noreply.github.com>
@devloves devloves marked this pull request as ready for review March 4, 2024 11:31
@devloves devloves requested review from a team as code owners March 4, 2024 11:31
@devloves devloves requested review from SquidXTV and christolis March 6, 2024 11:00
@Taz03 Taz03 self-assigned this Mar 10, 2024
@devloves devloves requested a review from christolis March 12, 2024 08:42
@Taz03 Taz03 merged commit 5ac1e07 into Together-Java:develop Mar 13, 2024
Taz03 added a commit that referenced this pull request Mar 13, 2024
* Added MemberCounter Routine

* feat: use pattern compile

* removed debug lines

* pattern fixes in config

* refactor: change cat to category

* feat: switch to findAny from forEach

* perf: remove pattern compilation for each call

Co-authored-by: Devansh Tiwari <65783463+devloves@users.noreply.github.com>

* perf: fixed solar linting error

* perf: made memberCountCategoryPattern required

* Update application/config.json.template

Co-authored-by: Chris Sdogkos <work@chris-sdogkos.com>

* fixed: routine not updating channel name after first write

* fixed comment

---------

Co-authored-by: christolis <work@chris-sdogkos.com>
Co-authored-by: Tanish Azad <tanishazad03@gmail.com>
@ankitsmt211 ankitsmt211 mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Members count display

4 participants