Skip to content

Log a warning if GitHubReference fails to initialize #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

christolis
Copy link
Member

Fixes #1020.

@christolis christolis requested review from a team as code owners February 21, 2024 14:49
@ankitsmt211
Copy link
Member

@christolis Please make sure to check if the issues are already assigned or if there's already active work related to a suggestion. By not doing so you're sort of wasting your time, someone else who already put some time into that issue or maintainers who put that time into reviewing/helping with it. With that said, i don't mind chris resolving this issue. I will assign it to them.

@marko-radosavljevic marko-radosavljevic merged commit e47a0ac into Together-Java:develop Feb 29, 2024
Taz03 pushed a commit that referenced this pull request Mar 6, 2024
* Catches the exception and logs when github key used in config is invalid. Otherwise, bot crashes, even when the feature is disabled.
@ankitsmt211 ankitsmt211 mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github commands package crashes all bot features if github key is not configured
5 participants