Server tests. #288 #289

romanstetsyk · 2023-01-25T18:28:47Z

Description

Added Jest tests for Express middleware:
To run tests: npm run test

Type of change

Please select everything applicable. Please, do not delete any lines.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Issue

Is this related to a specific issue? Is so please specify: Testing of the Express server #288 and Daylight Savings Time Bugs (THIS WAY LIES MANDESS) #302

Checklist:

This PR is up to date with the development branch, and merge conflicts have been resolved
I have executed npm run lint and resolved any outstanding errors. Most issues can be solved by executing npm run format
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings

romanstetsyk · 2023-01-25T18:33:39Z

server/app.js

@@ -0,0 +1,82 @@
+const express = require("express");
+const path = require("path");
+const app = express();


Express app and server needed to be separated into separate files so that app could be imported into the tests without starting the server

MatthewBozin · 2023-02-02T03:44:24Z

server/test/unit/createEventsArray.test.js

+    description: "starts and ends on the same UTC day",
+    input: {
+      ...commonFormFields,
+      firstEventStart: Date.parse("2023-01-28T15:00:00.000+00:00"),


I received typeerrors in all the tests in this sequence when I tried to run it! It looks like we're trying to feed the createEventsArray function an object with the properties "firstEventStart", "firstEventEnd", and "lastEventStart" when it's expecting to receive "initialDate", "finalDate", "startTime", and "endTime".

MatthewBozin · 2023-02-02T03:57:23Z

server/routes/events.js

@@ -10,8 +10,8 @@ const { createEventSchema } = require("../models/Event");
 router.post(
  "/",
  auth.ensureAuth,
-  validateBody(createEventSchema),
-  maxEvents,
+  // validateBody(createEventSchema),


It looks like when I uncomment these, creating an event returns a 400 error.

MatthewBozin · 2023-02-02T04:01:08Z

client/src/features/form/FormMoverControl.js

-        if (endDateTime < startDateTime) {
-          errorArray.push("Error: End time is before Start time");
-        }
+        // if (endDateTime < startDateTime) {


Do we want this to remain commented out?

MatthewBozin

Hey Roman!
I tried out the test suite! All test files worked fine except for createEventsArray (left a comment regarding the likely cause). While the app works fine, I noticed you've commented out a few of the form validation checks on the client and server side and wanted to know more about that before we merge this PR.
Thanks!
-Matt

romanstetsyk · 2023-02-02T12:48:58Z

@MatthewBozin thank you for reviewing this PR. This is a work in progress. It was made before we discovered bugs dealing with time zones and daylight-saving time. I am considering different approaches to solving this, and the tests haven't been updated yet.

MatthewBozin · 2023-02-02T21:08:23Z

Ah gotcha! Thanks for letting me know!

romanstetsyk · 2023-02-07T19:48:42Z

@MatthewBozin I've fixed the timezone bug (hopefully). Could you review the updated PR? We might need to add a warning when someone tries to create an event when time switches from normal to daylight-saving, as the display times may be misleading. But the most important thing is that in the database, the UTC times are saved correctly!

Caleb-Cohen · 2023-02-15T23:05:35Z

Added a commit please review.

* Added testing to pull request template * Feature/issue 314 (#319) * Install Cypress & needed packages Update eslint config Update gitignore Add testing development mongo path * Add nock Passport.js Discord request interception * Add Cypress tests * Disable server logging when testing * Fix delay-toggling environment variable Cypress wasn't properly listening to the CYPRESS_NO_DELAYS environment variable to disable the animations waits * added modulus to getHoursAndMinutes --------- Co-authored-by: Caleb Cohen <CalebCohen@hotmail.com> * starting workflow for actions * typo within review pull request * add environment dev to workflow * workflow changes * lint fixes (#324) * Actions timeout (#326) * Add timeout to GitHub actions GitHub action workflows should be limited so minutes aren't wasted if it hangs and bugs can be caught earlier. If 30 minutes isn't enough, it can be increased later on * change timeout to 10 minutes * Modified app metadata to "Together is a scheduling and collaboration … (#325) * Modified app metadata to "Together is a scheduling and collaboration tool built for and by 100Devs community for creating, discovering and keeping track of events on discord." * Deleted the extra space. * Server tests. #288 (#289) * install jest and supertest * separate app and server into different files * add jest coverage folder to gitignore * allow the use of mock user in test environment * change validateBody to be a sync function * add 'use strict', fix variable declarations * extract constants * remove console logs * add mock user to db * refactor, fix validation bugs in createEventSchema * test httpError * test validateObjectId * test validateBody * refactor unit tests * export STRING_MAX_LENGTH to be used in tests * fix dotenv path to work in tests * modify mock request * test routes * refactor maxEvents middleware * add tests for maxEvents * allow event end time (not date) to be before start time * test create event with valid data * timezone bug fix: add offset to days * test createEventArray * create date range with Date instead of datefns lib * test createEventsArray in JST timezone * refactor createEventsArray and tests * fix test JST time * use Temporal to work with dates * fix event duration using Temporal * test cases for createEventsArray * test validateBody * fix acceptance tests * change hardcoded timezone to machine timezone * update test script * remove irrelevant test (maxEvents) * update front-end test * add script to run all tests together * add route tests * added formidable, jsbi, moved jest and supertest to dev dependencies --------- Co-authored-by: Caleb Cohen <CalebCohen@hotmail.com> * Fix guest modal and and updated test (#327) * Fix guest modal and and updated test * author changes and lint fix * Make time-asserting code locale-based --------- Co-authored-by: Rascal_Two <therealrascaltwo@gmail.com> * Removed delete all button from non-recurring events (#332) * Removed delete all button from non-recurring events * Removed console.log from file * Feature/issue 305 (#339) * changed description section input element to textarea element. This change added multi-line functionality and a larger textbox size. * In the input object, I changed the input element text to textarea. Cypress now reflects the changes made in the codebase for proper testing. * Created a close button, in UserForm.js (#333) --------- Co-authored-by: Rascal Two <therealrascaltwo@gmail.com> Co-authored-by: Jacob Asper <jacobasper191@gmail.com> Co-authored-by: uaravindshenoy <75222342+uaravindshenoy@users.noreply.github.com> Co-authored-by: Roman Stetsyk <25715951+romanstetsyk@users.noreply.github.com> Co-authored-by: Lalysi <75863568+lalysi@users.noreply.github.com> Co-authored-by: Mike Jakuszewski <114702999+MikeJakuszewski@users.noreply.github.com> Co-authored-by: Jae Salaski <hello@jsalaski.com>

romanstetsyk added 23 commits January 20, 2023 18:58

install jest and supertest

4514ac2

separate app and server into different files

355fb8d

add jest coverage folder to gitignore

a129715

allow the use of mock user in test environment

68418f5

change validateBody to be a sync function

49bc2a8

add 'use strict', fix variable declarations

ead33ee

extract constants

f46d3da

remove console logs

b1ce0ec

add mock user to db

ae0a56d

refactor, fix validation bugs in createEventSchema

7a1da5a

test httpError

955feb6

test validateObjectId

07c1606

test validateBody

96a7d68

refactor unit tests

b66295a

export STRING_MAX_LENGTH to be used in tests

54f4ce4

fix dotenv path to work in tests

97fe831

modify mock request

ab1da48

test routes

48bb000

refactor maxEvents middleware

41e2826

add tests for maxEvents

62a9794

allow event end time (not date) to be before start time

2487a42

test create event with valid data

16b21ea

Merge branch 'development' into server-tests

fe7e81b

romanstetsyk commented Jan 25, 2023

View reviewed changes

romanstetsyk added 6 commits January 26, 2023 15:22

timezone bug fix: add offset to days

a362786

test createEventArray

be3122c

create date range with Date instead of datefns lib

36e9965

test createEventsArray in JST timezone

4209cd4

refactor createEventsArray and tests

2714185

Merge branch 'development' into server-tests

718db49

MatthewBozin reviewed Feb 2, 2023

View reviewed changes

MatthewBozin requested changes Feb 2, 2023

View reviewed changes

romanstetsyk added 4 commits February 7, 2023 14:59

test cases for createEventsArray

eebae6e

test validateBody

6ae950b

fix acceptance tests

70fa9a6

Merge branch 'development' into server-tests

c91f50e

romanstetsyk added 3 commits February 8, 2023 05:52

change hardcoded timezone to machine timezone

aea5b3e

Merge branch 'development' into server-tests

8cbd957

update test script

099302d

romanstetsyk temporarily deployed to DEV February 13, 2023 16:08 — with GitHub Actions Inactive

romanstetsyk added 2 commits February 14, 2023 00:11

Merge branch 'development' into server-tests

a9c9ee1

remove irrelevant test (maxEvents)

cea7784

romanstetsyk had a problem deploying to DEV February 14, 2023 00:13 — with GitHub Actions Error

romanstetsyk added 2 commits February 14, 2023 02:15

update front-end test

99359df

add script to run all tests together

af596a6

romanstetsyk temporarily deployed to DEV February 14, 2023 02:17 — with GitHub Actions Inactive

romanstetsyk requested a review from MatthewBozin February 14, 2023 02:21

add route tests

ce73c30

romanstetsyk temporarily deployed to DEV February 14, 2023 20:32 — with GitHub Actions Inactive

added formidable, jsbi, moved jest and supertest to dev dependencies

1eb314e

Caleb-Cohen temporarily deployed to DEV February 15, 2023 23:05 — with GitHub Actions Inactive

Caleb-Cohen merged commit 28e3b03 into Together-100Devs:development Feb 17, 2023

Caleb-Cohen mentioned this pull request Feb 17, 2023

Daylight Savings Time Bugs (THIS WAY LIES MANDESS) #302

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Server tests. #288 #289

Server tests. #288 #289

romanstetsyk commented Jan 25, 2023 •

edited

Loading

romanstetsyk Jan 25, 2023

MatthewBozin Feb 2, 2023

MatthewBozin Feb 2, 2023

MatthewBozin Feb 2, 2023

MatthewBozin left a comment

romanstetsyk commented Feb 2, 2023

MatthewBozin commented Feb 2, 2023

romanstetsyk commented Feb 7, 2023

Caleb-Cohen commented Feb 15, 2023

Server tests. #288 #289

Server tests. #288 #289

Conversation

romanstetsyk commented Jan 25, 2023 • edited Loading

Description

Type of change

Issue

Checklist:

romanstetsyk Jan 25, 2023

Choose a reason for hiding this comment

MatthewBozin Feb 2, 2023

Choose a reason for hiding this comment

MatthewBozin Feb 2, 2023

Choose a reason for hiding this comment

MatthewBozin Feb 2, 2023

Choose a reason for hiding this comment

MatthewBozin left a comment

Choose a reason for hiding this comment

romanstetsyk commented Feb 2, 2023

MatthewBozin commented Feb 2, 2023

romanstetsyk commented Feb 7, 2023

Caleb-Cohen commented Feb 15, 2023

romanstetsyk commented Jan 25, 2023 •

edited

Loading