Skip to content

Fix: Remove Postgres keepalives_idle default #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eakmanrq merged 1 commit into from
Apr 24, 2023
Merged

Fix: Remove Postgres keepalives_idle default #758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions docs/integrations/engines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,17 +150,17 @@ DuckDB only works when running locally; therefore it does not support Airflow.

# Postgres
## Postgres - Local/Built-in Scheduler
| Option | Description | Type | Required |
|-------------------|--------------------------------------------------------------------------------------------------------------------------------------|:------:|:--------:|
| `host` | The hostname of the Postgres server | string | Y |
| `user` | The username to use for authentication with the Postgres server | string | Y |
| `password` | The password to use for authentication with the Postgres server | string | Y |
| `port` | The port number of the Postgres server | int | Y |
| `database` | The name of the database instance to connect to | string | Y |
| `keepalives_idle` | The number of seconds between each keepalive packet sent to the server. If set to 0, the system default will be used. (Default: `0`) | int | N |
| `connect_timeout` | The number of seconds to wait for the connection to the server. (Default: `10`) | int | N |
| `role` | The role to use for authentication with the Postgres server | string | N |
| `sslmode` | The security of the connection to the Postgres server. | string | N |
| Option | Description | Type | Required |
|-------------------|---------------------------------------------------------------------------------|:------:|:--------:|
| `host` | The hostname of the Postgres server | string | Y |
| `user` | The username to use for authentication with the Postgres server | string | Y |
| `password` | The password to use for authentication with the Postgres server | string | Y |
| `port` | The port number of the Postgres server | int | Y |
| `database` | The name of the database instance to connect to | string | Y |
| `keepalives_idle` | The number of seconds between each keepalive packet sent to the server. | int | N |
| `connect_timeout` | The number of seconds to wait for the connection to the server. (Default: `10`) | int | N |
| `role` | The role to use for authentication with the Postgres server | string | N |
| `sslmode` | The security of the connection to the Postgres server. | string | N |

## Postgres - Airflow
**Engine Name:** `postgres`
Expand Down
2 changes: 1 addition & 1 deletion sqlmesh/core/config/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ class PostgresConnectionConfig(_ConnectionConfig):
password: str
port: int
database: str
keepalives_idle: int = 0
keepalives_idle: t.Optional[int]
connect_timeout: int = 10
role: t.Optional[str] = None
sslmode: t.Optional[str] = None
Expand Down