Fix: Make macro evaluator locals available from macro calls in jinja #5568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymao
approved these changes
Oct 30, 2025
crericha
force-pushed
the
load-locals-into-jinja-env
branch
from
6a0af8c to
66b078d
Compare
crericha
force-pushed
the
load-locals-into-jinja-env
branch
from
66b078d to
9f4d40d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the renderer, the locals were being loaded into the macro evaluator after the jinja environment is created. Move this logic to before the jinja environment is created, so that macros can be called from within jinja blocks.