Fix: Pass a copy of the properties to avoid mutation of actual dict#5417
Merged
themisvaltinos merged 2 commits intomainfrom Sep 19, 2025
Merged
Fix: Pass a copy of the properties to avoid mutation of actual dict#5417themisvaltinos merged 2 commits intomainfrom
themisvaltinos merged 2 commits intomainfrom
Conversation
eakmanrq
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update passes a copy of the rendered properties to avoid mutation before the second possible call.
When in SnapshotEvaluator's
evaluatewe are in a situation with a code path that leads to both create and insert to happen, since the create_view method internally pops the view_properties dictionary, this caused the second call to lose physical properties that were correctly applied in the first call. This pop always happened but this didn't occur before this: #5189 since these were in separate code paths. Added a test which should fail in main for this reason.