Fix: Move before all statements execution before snapshot creation logic#5229
Merged
themisvaltinos merged 2 commits intomainfrom Aug 26, 2025
Merged
Fix: Move before all statements execution before snapshot creation logic#5229themisvaltinos merged 2 commits intomainfrom
themisvaltinos merged 2 commits intomainfrom
Conversation
izeigerman
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix for scheduled runs moves the before_all statements so that they are executed first before any queries are made against the engine. The added test verifies the execution order, which should currently fail in main where the logic that determines which snapshots need to be created (added here: #5189) is before.