Skip to content

Fix: Use merge when updating auto restatements #5016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vchan merged 2 commits into from
Jul 25, 2025
Merged

Fix: Use merge when updating auto restatements #5016

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab3eeb2
Fix: Use merge instead over insert append when updating auto restatem…
vchan Jul 24, 2025
9af7718
More selective deletes
vchan Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions sqlmesh/core/state_sync/db/snapshot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,25 +373,31 @@ def update_auto_restatements(
Args:
next_auto_restatement_ts: A dictionary of snapshot name version to the next auto restatement timestamp.
"""
next_auto_restatement_ts_deleted = []
next_auto_restatement_ts_filtered = {}
for k, v in next_auto_restatement_ts.items():
if v is None:
next_auto_restatement_ts_deleted.append(k)
else:
next_auto_restatement_ts_filtered[k] = v

for where in snapshot_name_version_filter(
self.engine_adapter,
next_auto_restatement_ts,
next_auto_restatement_ts_deleted,
column_prefix="snapshot",
alias=None,
batch_size=self.SNAPSHOT_BATCH_SIZE,
):
self.engine_adapter.delete_from(self.auto_restatements_table, where=where)

next_auto_restatement_ts_filtered = {
k: v for k, v in next_auto_restatement_ts.items() if v is not None
}
if not next_auto_restatement_ts_filtered:
return

self.engine_adapter.insert_append(
self.engine_adapter.merge(
self.auto_restatements_table,
_auto_restatements_to_df(next_auto_restatement_ts_filtered),
columns_to_types=self._auto_restatement_columns_to_types,
unique_key=(exp.column("snapshot_name"), exp.column("snapshot_version")),
)

def count(self) -> int:
Expand Down