Fix!: Always recreate materialized view#4908
Merged
Conversation
georgesittas
approved these changes
Jul 4, 2025
izeigerman
reviewed
Jul 7, 2025
izeigerman
reviewed
Jul 7, 2025
izeigerman
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Materialized views in engines like BigQuery and Snowflake are invalidated if the underlying table(s) are replaced. Toy repro scenario:
This flow can be mirrored in the following toy SQLMesh project:
Running the very first plan will yield the following error in either engine, e.g:
This is because, during the plan:
t1is created as a dry runt2is created as a dry runt1is recreated/replaced as part of theFULLinsertion strategyViewStrategyit is not recreatedThis PR alters (4) such that any materialized view with upstream dependencies is recreated from scratch in order to restore correctness.