Skip to content

feat: vscode extension #4104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: vscode extension #4104

wants to merge 1 commit into from
+35,448 −2,367

Conversation

benfdking
Copy link
Contributor

@benfdking benfdking commented Apr 9, 2025 •
edited
Loading

Initial scope:

  • Format code -> through lsp
  • List diagnostics -> through diagnostics
  • Lineage view
    • Jump to model on file change
    • Click on node opens file

@benfdking benfdking force-pushed the vscode_extension branch 5 times, most recently from 8a0b89e to 2673372 Compare April 11, 2025 22:30
mykalmax
mykalmax reviewed Apr 15, 2025
View reviewed changes
vscode/extension/src/common/constants.ts Outdated

import * as path from 'path'

const folderName = path.basename(__dirname)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FOLDER_NAME ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just local to this folder and it is boilerplate.

mykalmax
mykalmax reviewed Apr 16, 2025
View reviewed changes
vscode/react/src/routes/index.tsx
target="_blank"
rel="noopener noreferrer"
>
Learn React
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example file

mykalmax
mykalmax reviewed Apr 16, 2025
View reviewed changes
vscode/react/src/logo.svg Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react logo

mykalmax
mykalmax reviewed Apr 16, 2025
View reviewed changes
vscode/react/src/hooks/vscode.ts Outdated
Comment on lines 9 to 17
// Use a different variable name to avoid conflict with the parameter
const eventPayload = {
key: callbackName,
payload: payload,
}
window.parent.postMessage({
key: "vscode_callback",
payload: eventPayload,
}, '*');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just use object directly payload: { ... }?

mykalmax
mykalmax reviewed Apr 16, 2025
View reviewed changes
vscode/react/index.html Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example file ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it's the base html

mykalmax
mykalmax reviewed Apr 16, 2025
View reviewed changes
vscode/extension/src/test/extension.test.ts Outdated
// You can import and use all API from the 'vscode' module
// as well as import your extension to test it
import * as vscode from 'vscode'
// import * as myExtension from '../../extension';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example ?

mykalmax
mykalmax reviewed Apr 16, 2025
View reviewed changes
vscode/extension/src/webviews/lineagePanel.ts Outdated
webviewView.webview.onDidReceiveMessage(
async (message) => {
console.log("message received", message);
if (message && message.key) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have a dedicated ConsoleLog() function to use when we need to log something and treat native console.log as part of dev debugging that needs to be removed ?

mykalmax
mykalmax reviewed Apr 16, 2025
View reviewed changes
vscode/extension/src/common/python.ts Outdated
Comment on lines 22 to 25
if (_api) {
return _api
}
_api = await PythonExtension.api()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe _api = _api || await PythonExtension.api()

mykalmax
mykalmax reviewed Apr 16, 2025
View reviewed changes
vscode/extension/src/common/python.ts Outdated
Comment on lines 30 to 46
try {
const api = await getPythonExtensionAPI()

if (api) {
disposables.push(
api.environments.onDidChangeActiveEnvironmentPath(async (e) => {
const environment = await api.environments.resolveEnvironment(e.path)
const isVirtualEnv = environment?.environment !== undefined
const binPath = isVirtualEnv ? environment?.environment?.folderUri.fsPath : undefined

onDidChangePythonInterpreterEvent.fire({
path: [e.path],
resource: e.resource?.uri,
isVirtualEnvironment: isVirtualEnv,
binPath
})
}),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is trying to catch Error initializing python and i think if await getPythonExtensionAPI() returns null that kinda like an error we want to catch here but having if (api) { prevents that

mykalmax
mykalmax reviewed Apr 16, 2025
View reviewed changes
vscode/extension/src/common/utilities.ts Outdated
Comment on lines 34 to 36
const level = logLevelToTrace(channelLogLevel <= globalLogLevel ? channelLogLevel : globalLogLevel)
return level
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just return logLevelToTrace(channelLogLevel <= globalLogLevel ? channelLogLevel : globalLogLevel)

@benfdking benfdking marked this pull request as draft April 17, 2025 15:45
@benfdking benfdking force-pushed the vscode_extension branch 8 times, most recently from 5cc30c2 to daa2f80 Compare April 24, 2025 11:47
@benfdking benfdking force-pushed the vscode_extension branch 7 times, most recently from a169a38 to 979751e Compare April 29, 2025 11:14
@benfdking benfdking force-pushed the vscode_extension branch 12 times, most recently from 29314f9 to 8906f30 Compare May 8, 2025 14:17
@benfdking benfdking force-pushed the vscode_extension branch 7 times, most recently from a0f2e94 to 2838b9c Compare May 9, 2025 12:00
@benfdking benfdking force-pushed the vscode_extension branch from 2838b9c to 1a583fc Compare May 9, 2025 12:09
@benfdking benfdking marked this pull request as ready for review May 9, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykalmax mykalmax mykalmax left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benfdking @mykalmax