feat: add ability to configure logging dir#2266
Merged
Conversation
eakmanrq
force-pushed
the
eakmanrq/make_logging_dir_configurable
branch
from
89786f8 to
81863a7
Compare
eakmanrq
force-pushed
the
eakmanrq/make_logging_dir_configurable
branch
from
81863a7 to
86ac7c2
Compare
izeigerman
approved these changes
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we assume all logging should go to a relative directly of "logs". This change makes it so that users of CLI or Magics can change the logging directory to where they want but default still to "logs".
Also included is a fix for tests so they use a function scoped path for the log files instead of sharing log directory with other tests.