Skip to content

Conversation

MrJohnMcClane
Copy link

I've added the Title, Mobile number, Phone number, Postal address and Company field to the VCard.

Copy link
Contributor

@T0biii T0biii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwarwick-bry
Copy link

I am also very interested in these fields. Here is a patch relative to the original PR submission to address @T0biii 's point, and also another that instead takes into account the subsequent module/repo restructure. I also added in one more field: URL (for a company website or a personal profile page).
vcard.patch
vcard_reorganized.patch

@T0biii
Copy link
Contributor

T0biii commented Mar 31, 2025

I am also very interested in these fields. Here is a patch relative to the original PR submission to address @T0biii 's point, and also another that instead takes into account the subsequent module/repo restructure. I also added in one more field: URL (for a company website or a personal profile page). vcard.patch vcard_reorganized.patch

can you open a pr with the paches?
So a maintainer can review and merge this?

@jwarwick-bry
Copy link

Sure, I just thought @MrJohnMcClane might wish to apply the patches and revise this PR. If he doesn't respond by the end of the week, I will submit a new PR to stand in stead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants