Add remove_label_when_approval_missing input.
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
do-not-remove-label-when-lost-approval-status
branch
4 times, most recently
from
ec9d6ae to
cedc828
Compare
Removing label when you lost or never had an approval status might not be what you desire to do. In some workflows when the label is manually set, removing it is automatically is harmful and it's better to leave the decision about removal to the commiters. Adding the parameter solves the problem.
potiuk
force-pushed
the
do-not-remove-label-when-lost-approval-status
branch
from
cedc828 to
23c6723
Compare
|
It's green now @TobKed |
TobKed
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing label when you lost or never had an approval status
might not be what you desire to do. In some workflows when
the label is manually set, removing it is automatically is
harmful and it's better to leave the decision about removal
to the commiters.
Adding the parameter solves the problem.