ConstructionMenu now properly unsubscribes from the keybind open even…

…t on the ConstructionSystem. This bug was previously causing an invisible disposed window to open back up after round start when pressing G, throwing exceptions and blocking mouse input.
ToastEnjoyer · Feb 27, 2021 · a9a3365 · a9a3365
1 parent 4cb59a0
commit a9a3365
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/Content.Client/Construction/ConstructionMenu.xaml.cs b/Content.Client/Construction/ConstructionMenu.xaml.cs
@@ -135,13 +135,5 @@ public void ClearRecipeInfo()
             TargetTexture.Texture = null;
             StepList.Clear();
         }
-
-        /// <inheritdoc />
-        protected override void Dispose(bool disposing)
-        {
-            base.Dispose(disposing);
-
-            if (disposing) { }
-        }
     }
 }
diff --git a/Content.Client/Construction/ConstructionMenuPresenter.cs b/Content.Client/Construction/ConstructionMenuPresenter.cs
@@ -123,6 +123,7 @@ public void Dispose()
         {
             _constructionView.Dispose();
 
+            SystemBindingChanged(null);
             _systemManager.SystemLoaded -= OnSystemLoaded;
             _systemManager.SystemUnloaded -= OnSystemUnloaded;