Skip to content

[Design] ChangeNode method is too strict #7

@remye06

Description

@remye06

Hello, I came across an implementation that was far away from what I was expecting while using the ChangeNode() method.
If the replacement string provided equals the current node's string representation, the method throws an exception with message "Same value".
I'm convinced that one would expect a no-op in that particular case, and that this implementation is very unnatural, at the very least.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions