Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix TIFFWSIReader read_bound #777

Merged
merged 27 commits into from
Jul 5, 2024

Conversation

vqdang
Copy link
Contributor

@vqdang vqdang commented Jan 29, 2024

image

Emergency bugfix per @John-P request.
The culprit is reading bound doesn't use the adjusted bounds as have been done in OpenSlideReader.

@shaneahmed shaneahmed added the bug Something isn't working label Feb 2, 2024
@shaneahmed shaneahmed added this to the Release v1.5.2 milestone Feb 2, 2024
@shaneahmed shaneahmed changed the title BUG: Fix TIFFWSIReader read bound 🐛 Fix TIFFWSIReader read_bound Feb 2, 2024
@shaneahmed
Copy link
Member

Thanks @vqdang and @John-P Please can you add a simple test to make sure this produces expected results.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (621a857) to head (a2c8afe).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #777      +/-   ##
===========================================
- Coverage    99.89%   99.86%   -0.04%     
===========================================
  Files           69       69              
  Lines         8650     8650              
  Branches      1653     1654       +1     
===========================================
- Hits          8641     8638       -3     
- Misses           1        4       +3     
  Partials         8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaneahmed shaneahmed linked an issue Feb 2, 2024 that may be closed by this pull request
@shaneahmed
Copy link
Member

Please can you also check if it is related to #499 ?

@Abdol
Copy link
Collaborator

Abdol commented May 13, 2024

I have added a simple test but not completely sure if it fully tests for the fixed bug. @vqdang @John-P I'd appreciate it if you can give the test a review.

@Abdol Abdol self-assigned this May 14, 2024
@Abdol Abdol requested a review from John-P May 14, 2024 11:02
@Abdol
Copy link
Collaborator

Abdol commented Jun 7, 2024

A kind follow up @vqdang @John-P. I'd appreciate it if you can give the test a review. Thanks!

@measty
Copy link
Collaborator

measty commented Jun 24, 2024

I think this also needs a fix along similar lines for read_rect

@Abdol
Copy link
Collaborator

Abdol commented Jun 25, 2024

A kind follow up @vqdang @John-P. I'd appreciate it if you can give the test a review. Thank you!

@Abdol Abdol added the help wanted Extra attention is needed label Jun 26, 2024
@measty
Copy link
Collaborator

measty commented Jun 27, 2024

I've added a few changes to this PR too.

  • fix for read_rect along similar lines to read_bounds (it was bugged in the same way)
  • a few changes to make the reader compatible with a wider variety of tiffs
  • a change to metadata in wsireader that fixes some performance issues on some wsis

@Abdol
Copy link
Collaborator

Abdol commented Jun 28, 2024

After updating the sample OME TIFF, the bug can be reproduced using the existing level consistency tests. So, I have removed the newly-added test. This PR should be good to go now.

@Abdol Abdol requested review from shaneahmed and removed request for John-P and mostafajahanifar June 28, 2024 15:01
Copy link
Member

@shaneahmed shaneahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Abdol , @measty and @vqdang for your help in fixing this bug.

@shaneahmed shaneahmed merged commit 82e9d8f into develop Jul 5, 2024
2 of 3 checks passed
@shaneahmed shaneahmed deleted the bugfix-tiffwsireader-readbounds branch July 5, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get ValueError: Unsupported axes YX when using OME-TIFF for nuclear segmentation Issues with TIFFWSIReader
4 participants