-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix TIFFWSIReader
read_bound
#777
Conversation
TIFFWSIReader
read bound TIFFWSIReader
read_bound
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #777 +/- ##
===========================================
- Coverage 99.89% 99.86% -0.04%
===========================================
Files 69 69
Lines 8650 8650
Branches 1653 1654 +1
===========================================
- Hits 8641 8638 -3
- Misses 1 4 +3
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Please can you also check if it is related to #499 ? |
I think this also needs a fix along similar lines for read_rect |
for more information, see https://pre-commit.ci
…TissueImageAnalytics/tiatoolbox into bugfix-tiffwsireader-readbounds
I've added a few changes to this PR too.
|
After updating the sample OME TIFF, the bug can be reproduced using the existing level consistency tests. So, I have removed the newly-added test. This PR should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emergency bugfix per @John-P request.
The culprit is reading bound doesn't use the adjusted bounds as have been done in OpenSlideReader.