✅ Upgrade remote sample fixtures #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #640 +/- ##
===========================================
- Coverage 99.78% 99.78% -0.01%
===========================================
Files 65 65
Lines 7075 7071 -4
Branches 1397 1397
===========================================
- Hits 7060 7056 -4
Misses 7 7
Partials 8 8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
blaginin
changed the title
shaneahmed
reviewed
Jul 18, 2023
shaneahmed
reviewed
Jul 18, 2023
shaneahmed
reviewed
Jul 18, 2023
shaneahmed
reviewed
Jul 18, 2023
shaneahmed
reviewed
Jul 18, 2023
shaneahmed
reviewed
Jul 18, 2023
tests/test_wsireader.py
Outdated
| @@ -2281,7 +2281,9 @@ class TestReader: | |||
| "type", | |||
| COLOR_DICT, | |||
| ), | |||
| "base_wsi": WSIReader.open(_fetch_remote_sample("svs-1-small")), | |||
| "base_wsi": WSIReader.open( | |||
| _fetch_remote_sample("svs-1-small") | |||
There was a problem hiding this comment.
Can you not use remote_sample here?
There was a problem hiding this comment.
Rewrote code a bit but yes. On the plus side, no need to use pytest_generate_tests — everything is happening here, using just native fixtures.
shaneahmed
reviewed
Jul 18, 2023
|
@blaginin Looks good to me. Just added a couple of minor suggestions. |
|
The new tests fixture has reduced coverage for dicom and AnnotationRenderer |
shaneahmed
approved these changes
Jul 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses part of issue #603 and improves fixtures in tests:
_fetch_remote_sampleeven though tests have a specialremote_samplewrapper.remote_samplepreviously created a new folder for each run (data-0, data-1, data-2, and so on). Now it uses just one folder for all remote fixtures during a test session._fetch_remote_sampleanddownload_datasince they had the same logic.