Skip to content

🚨 Use logger Instead Of warnings for wsi_registration.py #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shaneahmed merged 5 commits into from
May 5, 2023
Merged

🚨 Use logger Instead Of warnings for wsi_registration.py #587

shaneahmed merged 5 commits into from
May 5, 2023

Conversation

@shaneahmed
Copy link
Member

@shaneahmed shaneahmed commented Apr 10, 2023

  • Use logger Instead Of warnings for wsi_registration.py
  • Refactor duplicate code fragments

@shaneahmed
🚨 Use logger Instead Of warnings for wsi_registration.py
e4c2abf 
- Use `logger` Instead Of `warnings` for `wsi_registration.py`

Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
@shaneahmed
♻️ Refactor duplicate code fragments
8740ed6 
- Refactor duplicate code fragments

Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
@shaneahmed shaneahmed requested a review from ruqayya April 10, 2023 10:42
@shaneahmed shaneahmed added the enhancement New feature or request label Apr 10, 2023
@shaneahmed shaneahmed added this to the Release v1.4.0 milestone Apr 10, 2023
@shaneahmed shaneahmed self-assigned this Apr 10, 2023
@shaneahmed
🧪 Fix failing test
1236a32 
- Fix failing test

Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Apr 10, 2023 •
edited
Loading

Codecov Report

Merging #587 (661af62) into develop (df7655d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 661af62 differs from pull request most recent head b3ad233. Consider uploading reports for the commit b3ad233 to get more accurate results

@@             Coverage Diff             @@
##           develop     #587      +/-   ##
===========================================
+ Coverage    99.63%   99.66%   +0.03%     
===========================================
  Files           62       62              
  Lines         6609     6611       +2     
  Branches      1073     1073              
===========================================
+ Hits          6585     6589       +4     
+ Misses          15       14       -1     
+ Partials         9        8       -1
Impacted Files Coverage Δ
tiatoolbox/tools/registration/wsi_registration.py 100.00% <100.00%> (+0.49%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaneahmed
✅ Add test to improve coverage
661af62 
- Add test to improve coverage

Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
shaneahmed
shaneahmed commented Apr 11, 2023
View reviewed changes
@shaneahmed shaneahmed merged commit 1c42e39 into develop May 5, 2023
@shaneahmed shaneahmed deleted the dev-use-logger-for-wsi_registration branch May 5, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruqayya ruqayya Awaiting requested review from ruqayya

Assignees

@shaneahmed shaneahmed

Labels

enhancement New feature or request

Projects

None yet

Milestone

Release v1.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@shaneahmed