Skip to content

Conversation

@John-P
Copy link
Contributor

@John-P John-P commented Mar 18, 2022

Fix the stain normalisation CLI test which would dump output into the project root directory by specifying an output to a temporary test directory.

@John-P John-P requested review from Srijay-lab and shaneahmed March 18, 2022 14:03
@John-P John-P added the bug Something isn't working label Mar 18, 2022
Copy link
Member

@shaneahmed shaneahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @John-P Looks fine to me.

- Update micronet.py docstring
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #319 (8162ce7) into develop (40b1e1a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #319      +/-   ##
===========================================
- Coverage    99.84%   99.84%   -0.01%     
===========================================
  Files           55       55              
  Lines         5169     5168       -1     
  Branches       877      876       -1     
===========================================
- Hits          5161     5160       -1     
  Misses           2        2              
  Partials         6        6              
Impacted Files Coverage Δ
tiatoolbox/models/__init__.py 100.00% <ø> (ø)
tiatoolbox/models/architecture/hovernetplus.py 100.00% <ø> (ø)
tiatoolbox/models/architecture/idars.py 100.00% <ø> (ø)
tiatoolbox/models/architecture/micronet.py 100.00% <ø> (ø)
tiatoolbox/visualization/tileserver.py 100.00% <ø> (ø)
tiatoolbox/data/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a78210...8162ce7. Read the comment docs.

@shaneahmed shaneahmed merged commit 6e25ee7 into develop Mar 18, 2022
@shaneahmed shaneahmed deleted the test-stainnorm-output branch March 18, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants