-
Notifications
You must be signed in to change notification settings - Fork 102
DEV: Fix Makefile Docs Command #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
shaneahmed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you address my comment? Otherwise it looks fine to me.
Codecov Report
@@ Coverage Diff @@
## develop #316 +/- ##
===========================================
+ Coverage 99.82% 99.84% +0.02%
===========================================
Files 54 55 +1
Lines 5146 5169 +23
Branches 893 877 -16
===========================================
+ Hits 5137 5161 +24
Misses 2 2
+ Partials 7 6 -1
Continue to review full report at Codecov.
|
|
Have you tested running |
There was a bug in
make docswhere it would try to remove a directoryrm docs/_autosummarywithout the required-roption. This has been fixed in this PR. Also, aclean-docscommand has been added in addition to including generated files in the .gitignore file.