Skip to content

Conversation

@John-P
Copy link
Contributor

@John-P John-P commented Mar 4, 2022

Tidy docstrings in data, annotation etc.

  • Make line wrapping consistent.
  • Make indentation consistent
  • Remove unused import

@John-P John-P added the documentation Improvements or additions to documentation label Mar 4, 2022
@shaneahmed shaneahmed self-requested a review March 4, 2022 11:11
@John-P John-P self-assigned this Mar 4, 2022
Copy link
Member

@shaneahmed shaneahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @John-P
Please make the requested changes and we can merge.

@John-P
Copy link
Contributor Author

John-P commented Mar 4, 2022

Thanks for your suggestions @shaneahmed. I have addressed them all now.

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #311 (f94a135) into develop (ca0ece6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #311      +/-   ##
===========================================
- Coverage    99.82%   99.82%   -0.01%     
===========================================
  Files           54       54              
  Lines         5146     5145       -1     
  Branches       893      892       -1     
===========================================
- Hits          5137     5136       -1     
  Misses           2        2              
  Partials         7        7              
Impacted Files Coverage Δ
tiatoolbox/models/__init__.py 100.00% <ø> (ø)
tiatoolbox/models/architecture/idars.py 100.00% <ø> (ø)
tiatoolbox/visualization/tileserver.py 100.00% <ø> (ø)
tiatoolbox/data/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca0ece6...f94a135. Read the comment docs.

@John-P
Copy link
Contributor Author

John-P commented Mar 11, 2022

Unsure why codecov is complaining here. It says there is no change when you click through. I think that it's just the change in line count altering the calculated number.

@John-P John-P requested a review from shaneahmed March 18, 2022 01:46
Copy link
Member

@shaneahmed shaneahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @John-P

@shaneahmed shaneahmed merged commit 6a78210 into develop Mar 18, 2022
@shaneahmed shaneahmed deleted the doc-tidy-misc branch March 18, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants