Skip to content

Conversation

@shaneahmed
Copy link
Member

@shaneahmed shaneahmed commented Feb 18, 2022

  • Add micronet architecture.
  • Add Consep trained model.

@shaneahmed shaneahmed self-assigned this Feb 18, 2022
@shaneahmed shaneahmed added the enhancement New feature or request label Feb 18, 2022
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #293 (3236432) into develop (b182489) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #293    +/-   ##
=========================================
  Coverage    99.82%   99.82%            
=========================================
  Files           53       54     +1     
  Lines         5004     5146   +142     
  Branches       823      825     +2     
=========================================
+ Hits          4995     5137   +142     
  Misses           2        2            
  Partials         7        7            
Impacted Files Coverage Δ
tiatoolbox/models/architecture/__init__.py 100.00% <100.00%> (ø)
tiatoolbox/models/architecture/hovernet.py 100.00% <100.00%> (ø)
tiatoolbox/models/architecture/hovernetplus.py 100.00% <100.00%> (ø)
tiatoolbox/models/architecture/micronet.py 100.00% <100.00%> (ø)
tiatoolbox/models/architecture/utils.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b182489...3236432. Read the comment docs.

@shaneahmed shaneahmed requested a review from vqdang February 21, 2022 09:27
@shaneahmed shaneahmed changed the title ENH: Add micronet NEW: Add micronet Feb 21, 2022
- Update docstrings for various Micronet functions.
- Upload micronet consep model.
Update models/architecture/micronet.py to work with tiatoolbox
- Add tests for micronet.
- Fix spelling errors in tests/models/test_hovernet
- Fix linter issues.
- Fix deepsource bugs
- Fix deepsource errors
- Update the forward function to accept args and kwargs
@shaneahmed shaneahmed marked this pull request as ready for review February 21, 2022 18:17
- Update abc to include input_images in modelabc
- Add map_location to tests
- Update forward input
- Update MicroNet docstring.
- Update docs to include micronet
- update docstring for micronet
- Skip potential bug error
- update docstring
- Update docstring
- Add performance table to micronet
- Add tests to improve coverage.
- Update __init__ to include fetch_pretrained_weights

"""

def group1_branch(layer, in_tensor, resized_feat):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the below group functions be better defined in init under a slight different name such as group_link? Makes forward quite clunky otherwise.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in this commit 9af1c00

- Rearrange group functions to clean the code.
Copy link
Contributor

@vqdang vqdang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaneahmed Can you add a functional test for the precision of the output? You will use the conditional decorator to flag that test for local run only?

Otherwise, I am fine with this.

- Update MicroNet to add local test and post process nuclei
- Fix micronet test to take two outputs from postproc.
@shaneahmed shaneahmed merged commit ca0ece6 into develop Feb 24, 2022
@shaneahmed shaneahmed deleted the enh-add-micronet branch February 24, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants