-
Notifications
You must be signed in to change notification settings - Fork 102
NEW: Add micronet
#293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW: Add micronet
#293
Conversation
- Fix HoVerNet plus documentation
- Add models/architecture/micronet
Codecov Report
@@ Coverage Diff @@
## develop #293 +/- ##
=========================================
Coverage 99.82% 99.82%
=========================================
Files 53 54 +1
Lines 5004 5146 +142
Branches 823 825 +2
=========================================
+ Hits 4995 5137 +142
Misses 2 2
Partials 7 7
Continue to review full report at Codecov.
|
- Fix deepsource errors
- Add docstring for weights initialization
- Update docstrings for various Micronet functions.
- Upload micronet consep model.
Update models/architecture/micronet.py to work with tiatoolbox
- Add tests for micronet.
- Fix spelling errors in tests/models/test_hovernet - Fix linter issues.
- Fix deepsource bugs
- Fix deepsource errors
- Update the forward function to accept args and kwargs
- Update abc to include input_images in modelabc
- Add map_location to tests
- Update forward input - Update MicroNet docstring.
- Update docs to include micronet
- update docstring for micronet
- Skip potential bug error
- update docstring
- Update docstring
- Add performance table to micronet
- Add tests to improve coverage.
- Update __init__ to include fetch_pretrained_weights
|
|
||
| """ | ||
|
|
||
| def group1_branch(layer, in_tensor, resized_feat): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the below group functions be better defined in init under a slight different name such as group_link? Makes forward quite clunky otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in this commit 9af1c00
- Rearrange group functions to clean the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shaneahmed Can you add a functional test for the precision of the output? You will use the conditional decorator to flag that test for local run only?
Otherwise, I am fine with this.
- Update MicroNet to add local test and post process nuclei
- Fix micronet test to take two outputs from postproc.
micronetarchitecture.