Skip to content

Conversation

@Srijay-lab
Copy link
Contributor

@Srijay-lab Srijay-lab commented Feb 11, 2022

  • Update scikit image version to 0.19.1

@John-P John-P changed the title Update scikit image version DEV: Update scikit-image Version Feb 11, 2022
@shaneahmed shaneahmed linked an issue Feb 11, 2022 that may be closed by this pull request
@shaneahmed shaneahmed requested a review from John-P February 11, 2022 10:41
@John-P
Copy link
Contributor

John-P commented Feb 11, 2022

We should update all of the requirements files if possible to keep the versions consistent.

@John-P John-P added bug Something isn't working dev tools Changes/Updates in Development tools release labels Feb 11, 2022
@John-P
Copy link
Contributor

John-P commented Feb 11, 2022

Currently investigating why the scikit-image update changes phase_cross_correlation and breaks tests.

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #284 (cbe12a2) into develop (c7a3728) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #284   +/-   ##
========================================
  Coverage    99.82%   99.82%           
========================================
  Files           53       53           
  Lines         5003     5004    +1     
  Branches       824      823    -1     
========================================
+ Hits          4994     4995    +1     
  Misses           2        2           
  Partials         7        7           
Impacted Files Coverage Δ
tiatoolbox/tools/graph.py 100.00% <0.00%> (ø)
tiatoolbox/tools/stainnorm.py 100.00% <0.00%> (ø)
tiatoolbox/tools/patchextraction.py 100.00% <0.00%> (ø)
tiatoolbox/models/architecture/utils.py 100.00% <0.00%> (ø)
tiatoolbox/models/architecture/hovernet.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a53684a...cbe12a2. Read the comment docs.

@shaneahmed
Copy link
Member

@Srijay-lab please also update setup.py

- Update `setup.py` fro scikit-image-version
@shaneahmed
Copy link
Member

Copy link
Member

@shaneahmed shaneahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Srijay-lab

@shaneahmed shaneahmed merged commit 0250fdc into develop Feb 24, 2022
@shaneahmed shaneahmed deleted the bug-scikit-image-version branch February 24, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dev tools Changes/Updates in Development tools release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEV: Update scikit-image

4 participants