-
Notifications
You must be signed in to change notification settings - Fork 102
NEW: Add DICOM Read Support #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add a new DICOMWSIReader for reading DICOM WSIs. - Refactor some code to reduce complexity and move private functions from WSIReader to WSIMeta where appropriate.
Codecov Report
@@ Coverage Diff @@
## develop #270 +/- ##
========================================
Coverage 99.81% 99.82%
========================================
Files 53 53
Lines 4934 5003 +69
Branches 816 824 +8
========================================
+ Hits 4925 4994 +69
Misses 2 2
Partials 7 7
Continue to review full report at Codecov.
|
|
@shaneahmed Looks like it's just black causing it to fail now. Fixed the coverage to 100% on patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Looks good to me. A few changes and we should be ready to merge.
Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
…toolbox into feature-dicom-reader
Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
…toolbox into feature-dicom-reader
shaneahmed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am leaving this to your judgement otherwise I am approving this PR.
#270 (comment)
vqdang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments. Why do I see here and there edit within TiffReader? Also, some helper function may perhap should be migrated to base class in the future (us time validation, shape conversion)
|
@vqdang I have not modified TiffReader. It may have been caused by someone merging changes merged in from develop or from a change in the Black style guide which happened during this PR e.g. |
I merged these as the new version of black fails on |
Ah yes I just mixed up the way round the change happened for |
Main Changes
DICOMWSIReaderfor reading DICOM WSIs. Very similar toOpenSlideWSIReader.from
WSIReadertoWSIMetawhere appropriate.level_downsampletoWSIMetato calculate the downsample for a level as it only requires access to information in the metadata object (sizes of levels in the pyramid).relative_level_scalestoWSIMetaas it only depends onlevel_downsampleand data from the metadata object.Additional Changes