Fix ModalPage issue (#18) #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you use TinyNavigationHelper with TinyMvvm? If that the case it would be great if you create a PR for the 3.0 branch of TinyMvvm instead. |
|
I do not use TinyMvvm, but i still can create a pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes(#18) the problem when you open modal page with withNavigation parameter set to true and close the modal page not using the CloseModalAsync method and as result you get a broken navigation because the global parameter _modalNavigationPage is not null.
Not sure if this is the best way to fix this problem, but it does its job.