Skip to content

Conversation

@vncloudsco
Copy link
Contributor

  • Updated variable references to use double quotes for better safety and consistency across deploy.sh, install-nginx-modsecurity.sh, quickstart.sh, and start.sh.
  • Enhanced readability by ensuring uniformity in variable usage.

Copilot AI review requested due to automatic review settings October 3, 2025 15:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors shell scripts to improve variable quoting consistency and safety by wrapping variable references in double quotes. The changes enhance protection against word splitting and pathname expansion issues that can occur with unquoted variables in bash.

  • Updated all variable references to use double quotes ("${VAR}" instead of $VAR)
  • Applied consistent quoting patterns across deploy.sh, install-nginx-modsecurity.sh, quickstart.sh, and start.sh
  • Maintained script functionality while improving robustness

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
scripts/start.sh Updated variable references to use double quotes for paths, PIDs, and process handling
scripts/quickstart.sh Applied consistent double quoting to database configuration, Docker commands, and process variables
scripts/install-nginx-modsecurity.sh Enhanced variable quoting in logging, configuration paths, and system commands
scripts/deploy.sh Standardized variable quoting for database setup, service configuration, and deployment parameters

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
25.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@vncloudsco vncloudsco merged commit cf39b42 into TinyActive:main Oct 3, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant